Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Assay to connect to Prod, Stage and Dev environments #91

Open
abyrne-moz opened this issue Jul 25, 2024 · 3 comments · May be fixed by #105
Open

Allow Assay to connect to Prod, Stage and Dev environments #91

abyrne-moz opened this issue Jul 25, 2024 · 3 comments · May be fixed by #105
Labels
nice-to-have Functionality or features that would be nice to have in Assay.

Comments

@abyrne-moz
Copy link

Provide functionality for a reviewer to decide which environment Assay opens and connects to

  1. Production
  2. Stage
  3. Dev
@abyrne-moz abyrne-moz added the nice-to-have Functionality or features that would be nice to have in Assay. label Jul 25, 2024
@chrstinalin chrstinalin linked a pull request Jul 31, 2024 that will close this issue
@chrstinalin
Copy link
Contributor

Switching between environments may not work out since the databases are different.

For example, take I install add-on with ID 64 in dev, and I then switch to stage. That ID may point to a different add-on now. This is likely to confuse Assay -- for one, since linter messages are actively fetched by ID, the fetched results may not exist or be for a different add-on entirely.

For more context, in which scenarios is this utilized?

@abyrne-moz
Copy link
Author

I think the goal would be to "open VSCode + Assay" connected to an environment for that particular session, or at least open it and have it connect to the last environment you connected to. I don't believe that a reviewer will switch environments mid review.

This is so that if a bug is found in Assay or a reviewer wants to test something, they can easily connect to a different environment to complete that test or validate a bug.

@chrstinalin
Copy link
Contributor

(Discussed this further on Slack) Since the context is to open Assay in Dev/Stage just to validate any bugs they find or test things, note that this is already possible by building Assay from the source code (and all they'd need to do is follow the instructions in the README.MD).
image

However, VS Code will sync settings across any versions of the extension, so the aforementioned problem still exists (any add-ons you installed in production will still exist in the development environment unless you manually change the addons root folder in settings.)

@willdurand @wagnerand for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice-to-have Functionality or features that would be nice to have in Assay.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants