Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refresh] Footer contains an empty list item #15892

Open
alexgibson opened this issue Jan 20, 2025 · 0 comments · May be fixed by #15913
Open

[Refresh] Footer contains an empty list item #15892

alexgibson opened this issue Jan 20, 2025 · 0 comments · May be fixed by #15913
Labels
Bug 🐛 Something's not working the way it should Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome Refresh 🦖 Work related to the 2024 site refresh

Comments

@alexgibson
Copy link
Member

Description

There's an empty list item in the footer links that creates uneven spacing on the German footer.

https://github.com/mozilla/bedrock/blob/main/bedrock/base/templates/includes/protocol/footer/footer-refresh.html#L24-L26

Steps to reproduce

This is only visible on the German footer:

Image

https://www.mozilla.org/de/

Expected result

No empty space

Actual result

Empty space

Environment

Firefox Nightly
macOS
@alexgibson alexgibson added Bug 🐛 Something's not working the way it should Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome Refresh 🦖 Work related to the 2024 site refresh labels Jan 20, 2025
@MachaVivek MachaVivek linked a pull request Jan 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 Something's not working the way it should Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome Refresh 🦖 Work related to the 2024 site refresh
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: removed empty list item in the footer links that creates uneven s… MachaVivek/bedrock
1 participant
@alexgibson