From f08483e0b64ca871369dacc4bca466bac73bb4ee Mon Sep 17 00:00:00 2001 From: Florian Zia Date: Sat, 28 Sep 2024 14:33:48 +0200 Subject: [PATCH] chore: Only set max failures for E2E tests that are running on PRs --- .github/workflows/e2e_cron.yml | 2 +- .github/workflows/e2e_pr_full.yml | 2 +- playwright.config.js | 3 --- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/e2e_cron.yml b/.github/workflows/e2e_cron.yml index 33750b7dcf8..5901721064b 100644 --- a/.github/workflows/e2e_cron.yml +++ b/.github/workflows/e2e_cron.yml @@ -76,7 +76,7 @@ jobs: name: test-results path: src/e2e/test-results/ retention-days: 30 - + - name: Send GitHub Action trigger data to Slack workflow id: slack uses: slackapi/slack-github-action@v1.27.0 diff --git a/.github/workflows/e2e_pr_full.yml b/.github/workflows/e2e_pr_full.yml index 7bb713cbace..71811390e91 100644 --- a/.github/workflows/e2e_pr_full.yml +++ b/.github/workflows/e2e_pr_full.yml @@ -59,7 +59,7 @@ jobs: - name: Run Playwright tests if: github.actor != 'dependabot[bot]' - run: npm run e2e -- --update-snapshots + run: npm run e2e -- --max-failures=1 --update-snapshots timeout-minutes: 20 env: E2E_TEST_ENV: local diff --git a/playwright.config.js b/playwright.config.js index f400189f150..a7315ed3b5a 100644 --- a/playwright.config.js +++ b/playwright.config.js @@ -50,9 +50,6 @@ export default defineConfig({ /* Fail the build on CI if you accidentally left test.only in the source code. */ forbidOnly: !!process.env.CI, - /* Limit the number of failures */ - maxFailures: 1, - /* Retry on CI only */ retries: process.env.CI ? 1 : 0,