From 92e19c3723d4062a472720d3e15af2e7f5b02542 Mon Sep 17 00:00:00 2001 From: Florian Zia Date: Mon, 21 Oct 2024 14:42:14 +0200 Subject: [PATCH 1/5] chore: Update all breaches page title --- locales/en/app.ftl | 2 +- locales/en/breaches.ftl | 3 +-- .../(redesign)/(public)/breaches/BreachIndexView.tsx | 2 +- .../(proper_react)/(redesign)/(public)/breaches/page.tsx | 6 +++--- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/locales/en/app.ftl b/locales/en/app.ftl index e66dd9f43cd..1efb0ce72c8 100644 --- a/locales/en/app.ftl +++ b/locales/en/app.ftl @@ -242,7 +242,7 @@ error-page-error-other-title = { $errorCode } Something went wrong ## Breach overview page -all-breaches-headline-2 = All breaches detected by { -brand-fx-monitor } +all-breaches-headline-3 = Data Breach Database all-breaches-lead = We monitor all known data breaches to find out if your personal information was compromised. Here’s a complete list of all of the breaches that have been reported since 2007. search-breaches = Search Breaches diff --git a/locales/en/breaches.ftl b/locales/en/breaches.ftl index 9d0c3867116..70b911d7fa9 100644 --- a/locales/en/breaches.ftl +++ b/locales/en/breaches.ftl @@ -2,8 +2,7 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -breach-all-meta-title = { -brand-fx-monitor } - All Data Breaches -breach-all-meta-social-title = All Breaches Detected by { -brand-fx-monitor } +breach-all-meta-page-title = Data Breach Database - { -brand-fx-monitor } breach-all-meta-social-description = Browse the complete list of known breaches detected by { -brand-fx-monitor }, then find out if your information was exposed. # Variables: diff --git a/src/app/(proper_react)/(redesign)/(public)/breaches/BreachIndexView.tsx b/src/app/(proper_react)/(redesign)/(public)/breaches/BreachIndexView.tsx index 71cf16464ed..28b82f5f408 100644 --- a/src/app/(proper_react)/(redesign)/(public)/breaches/BreachIndexView.tsx +++ b/src/app/(proper_react)/(redesign)/(public)/breaches/BreachIndexView.tsx @@ -25,7 +25,7 @@ export const BreachIndexView = (props: Props) => { return (
-

{l10n.getString("all-breaches-headline-2")}

+

{l10n.getString("all-breaches-headline-3")}

{l10n.getString("all-breaches-lead")}

{ diff --git a/src/app/(proper_react)/(redesign)/(public)/breaches/page.tsx b/src/app/(proper_react)/(redesign)/(public)/breaches/page.tsx index 3bdb6808b48..5cb3e649697 100644 --- a/src/app/(proper_react)/(redesign)/(public)/breaches/page.tsx +++ b/src/app/(proper_react)/(redesign)/(public)/breaches/page.tsx @@ -9,15 +9,15 @@ import { BreachIndexView } from "./BreachIndexView"; export function generateMetadata() { const l10n = getL10n(); return { - title: l10n.getString("breach-all-meta-title"), + title: l10n.getString("breach-all-meta-page-title"), twitter: { card: "summary_large_image", - title: l10n.getString("breach-all-meta-social-title"), + title: l10n.getString("all-breaches-headline-3"), description: l10n.getString("breach-all-meta-social-description"), images: ["/images/og-image.webp"], }, openGraph: { - title: l10n.getString("breach-all-meta-social-title"), + title: l10n.getString("all-breaches-headline-3"), description: l10n.getString("breach-all-meta-social-description"), siteName: l10n.getString("brand-fx-monitor"), type: "website", From 94bba8084ca754daaaeb40b818f6fd019eec08a0 Mon Sep 17 00:00:00 2001 From: Florian Zia Date: Wed, 23 Oct 2024 14:35:49 +0200 Subject: [PATCH 2/5] chore: Update breach details page title --- locales/en/breaches.ftl | 3 +++ .../(redesign)/(public)/breach-details/[breachName]/page.tsx | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/locales/en/breaches.ftl b/locales/en/breaches.ftl index 70b911d7fa9..6d182c5c2d8 100644 --- a/locales/en/breaches.ftl +++ b/locales/en/breaches.ftl @@ -5,6 +5,9 @@ breach-all-meta-page-title = Data Breach Database - { -brand-fx-monitor } breach-all-meta-social-description = Browse the complete list of known breaches detected by { -brand-fx-monitor }, then find out if your information was exposed. +# Variables: +# $company (String) - Name of the company that was breached, e.g. "PHP Freaks" +breach-detail-meta-page-title = { $company } Data Breach - { -brand-fx-monitor } # Variables: # $company (String) - Name of the company that was breached, e.g. "PHP Freaks" breach-detail-meta-social-title = Were you affected by the { $company } Data Breach? diff --git a/src/app/(proper_react)/(redesign)/(public)/breach-details/[breachName]/page.tsx b/src/app/(proper_react)/(redesign)/(public)/breach-details/[breachName]/page.tsx index 3ae109cd3d1..6bc7ff961d3 100644 --- a/src/app/(proper_react)/(redesign)/(public)/breach-details/[breachName]/page.tsx +++ b/src/app/(proper_react)/(redesign)/(public)/breach-details/[breachName]/page.tsx @@ -20,7 +20,9 @@ export async function generateMetadata(props: { } return { - title: `${l10n.getString("brand-mozilla-monitor")} - ${breach.Title}`, + title: l10n.getString("breach-detail-meta-page-title", { + company: breach.Title, + }), twitter: { card: "summary_large_image", title: l10n.getString("breach-detail-meta-social-title", { From 0ae1277a5b6d5e82485302b91167a0084f580dea Mon Sep 17 00:00:00 2001 From: Florian Zia Date: Wed, 23 Oct 2024 19:23:16 +0200 Subject: [PATCH 3/5] chore: Revert meta title for socials on breaches page --- locales/en/breaches.ftl | 1 + src/app/(proper_react)/(redesign)/(public)/breaches/page.tsx | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/locales/en/breaches.ftl b/locales/en/breaches.ftl index 6d182c5c2d8..a8e5fe38f11 100644 --- a/locales/en/breaches.ftl +++ b/locales/en/breaches.ftl @@ -3,6 +3,7 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. breach-all-meta-page-title = Data Breach Database - { -brand-fx-monitor } +breach-all-meta-social-title = All Breaches Detected by { -brand-fx-monitor } breach-all-meta-social-description = Browse the complete list of known breaches detected by { -brand-fx-monitor }, then find out if your information was exposed. # Variables: diff --git a/src/app/(proper_react)/(redesign)/(public)/breaches/page.tsx b/src/app/(proper_react)/(redesign)/(public)/breaches/page.tsx index 5cb3e649697..73023b4a915 100644 --- a/src/app/(proper_react)/(redesign)/(public)/breaches/page.tsx +++ b/src/app/(proper_react)/(redesign)/(public)/breaches/page.tsx @@ -12,12 +12,12 @@ export function generateMetadata() { title: l10n.getString("breach-all-meta-page-title"), twitter: { card: "summary_large_image", - title: l10n.getString("all-breaches-headline-3"), + title: l10n.getString("breach-all-meta-social-title"), description: l10n.getString("breach-all-meta-social-description"), images: ["/images/og-image.webp"], }, openGraph: { - title: l10n.getString("all-breaches-headline-3"), + title: l10n.getString("breach-all-meta-social-title"), description: l10n.getString("breach-all-meta-social-description"), siteName: l10n.getString("brand-fx-monitor"), type: "website", From d105c53cb21d05f26f944d6c9144318bbb060c9e Mon Sep 17 00:00:00 2001 From: Florian Zia Date: Thu, 24 Oct 2024 14:58:11 +0200 Subject: [PATCH 4/5] Update locales/en/breaches.ftl Use em dash in `breach-all-meta-page-title`. Co-authored-by: Francesco Lodolo --- locales/en/breaches.ftl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/locales/en/breaches.ftl b/locales/en/breaches.ftl index a8e5fe38f11..0f87585cac4 100644 --- a/locales/en/breaches.ftl +++ b/locales/en/breaches.ftl @@ -2,7 +2,7 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. -breach-all-meta-page-title = Data Breach Database - { -brand-fx-monitor } +breach-all-meta-page-title = Data Breach Database — { -brand-fx-monitor } breach-all-meta-social-title = All Breaches Detected by { -brand-fx-monitor } breach-all-meta-social-description = Browse the complete list of known breaches detected by { -brand-fx-monitor }, then find out if your information was exposed. From fbb39fd8cbf0815cb0ecc7da52939da31d1fa59e Mon Sep 17 00:00:00 2001 From: Florian Zia Date: Thu, 24 Oct 2024 15:01:06 +0200 Subject: [PATCH 5/5] chore: Use em dash in breach-detail-meta-page-title --- locales/en/breaches.ftl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/locales/en/breaches.ftl b/locales/en/breaches.ftl index a8e5fe38f11..378d36bcc9e 100644 --- a/locales/en/breaches.ftl +++ b/locales/en/breaches.ftl @@ -8,7 +8,7 @@ breach-all-meta-social-description = Browse the complete list of known breaches # Variables: # $company (String) - Name of the company that was breached, e.g. "PHP Freaks" -breach-detail-meta-page-title = { $company } Data Breach - { -brand-fx-monitor } +breach-detail-meta-page-title = { $company } Data Breach – { -brand-fx-monitor } # Variables: # $company (String) - Name of the company that was breached, e.g. "PHP Freaks" breach-detail-meta-social-title = Were you affected by the { $company } Data Breach?