Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Makefile into "inner" and "outer" Makefiles #11667

Open
data-sync-user opened this issue Oct 31, 2024 · 0 comments
Open

Refactor Makefile into "inner" and "outer" Makefiles #11667

data-sync-user opened this issue Oct 31, 2024 · 0 comments
Assignees

Comments

@data-sync-user
Copy link
Collaborator

Our makefiles are responsible for running all of our tasks, but several targets are shaped like:

target: dep1 dep2 dep3

dep1:
  docker run dep1
  
dep2:
  docker run dep2

dep3:
  docker run dep3

or

TASK1 = some bash command
TASK2 = some other bash command

target:
  docker run sh -c "${TASK1} && ${TASK2}"

It would be nice if we could refactor this out into a top level makefile that is responsible for running all the top level tasks, which shell out to docker run <container> make <inner-target>. This should result in a cleaner and more managable task system without adding additional third party dependencies.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants