Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nuances of "in source" better #1000

Open
wlach opened this issue Dec 7, 2021 · 1 comment
Open

Handle nuances of "in source" better #1000

wlach opened this issue Dec 7, 2021 · 1 comment

Comments

@wlach
Copy link
Contributor

wlach commented Dec 7, 2021

Currently our concept of "in source" only considers the latest version of a product, but it's possible in some cases for a metric to be still "in source" on other channels even if it's expired there. The most common case is where a metric is removed on the nightly channel of an application, but remains on beta and/or release.

in_source=metric.definition["in_source"],

For applications like Firefox for Android with multiple app identifiers, this is easy to detect since metrics are segmented by app id (and are just amalgamated by our ETL). In that case we should probably not consider a metric removed on all channels unless it actually is (instead we should move to a per-channel notion of removed?).

This is more difficult for Firefox Desktop: perhaps updating the warning banner in the glean dictionary is the best we can do.

/cc @chutten

@chutten
Copy link
Contributor

chutten commented Dec 7, 2021

We could make Glean Dictionary aware of Firefox Desktop's channels in a similar means to Firefox for Android's. gecko-dev has beta and release channels we could specify in probe-scraper's repositories.yaml. I did think about it, but went for the more straightforward app declaration to keep things from sprawling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants