move calls to get_settings outside of __init__
#496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phijma-leukeleu
commented
Jun 22, 2023
Comment on lines
+50
to
+52
| @cached_property | ||
| def settings(self): | ||
| retval = { |
There was a problem hiding this comment.
@stevenbal is this going to break our library?
There was a problem hiding this comment.
With the way our library is implemented now: yes, because we rely on overriding get_settings
There was a problem hiding this comment.
I don't think this is too much of a problem? I don't see any changes to that method in particular and instead it will allow us to remove our __init__ override since settings are now consumed lazily. So, what am I missing? 😄
There was a problem hiding this comment.
Whoops, I skimmed over it too quickly and thought get_settings was removed here altogether 😅. You're right, this should work and the init override can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View, middleware and auth backend
Fixes #495