-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form select elements don't match styling when disabled #885
Comments
Hey @stephaniehobson , is this fixed? |
@Ayushsunny Doesn't seem like it, feel free to pick it up if you'd like |
@reemhamz How to reproduce this issue? |
There are two options. The caret colour can match the border like it does in all other states (currently drafted in #959): or it can be simplified even more, and for better contrast with the disabled grey background the caret can just default to its initial colour: (I briefly preferred the latter, but after some time went with the former for consistency…) @stephaniehobson Do you have a preference? |
I don't have much of an opinion here either but since my vague leaning is also your vague leaning let's go with the latter for better contrast and more simplicity. |
Ack. The explicit fourth state variable can always be added later if deemed necessary, for now this saves one sass:string-based recursive uriencoding when compiling. @stephaniehobson For comparison the former preview was here, the latter can now be testdriven here, feel free to torture the controls to your liking and whenever you're happy with what you see you can always hit that green button… |
Description
When a select drop down is disabled it gains a filled blue triangle as the down arrow. This is incongruous with the carrot the select uses for other states and I would expect it to be grey.
Steps to reproduce
disabled
to the select elementExpected result
Actual result
Environment
MacOS, Firefox Nightly.
The text was updated successfully, but these errors were encountered: