Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go all-in on CSS custom properties for themes, remove Sass variables #982

Open
craigcook opened this issue Sep 17, 2024 · 0 comments
Open
Labels
Discussion 🚲 Something we need to discuss

Comments

@craigcook
Copy link
Member

Much of the preliminary work we've done in bedrock for the new Mozilla branding has hinged on custom properties and eschewed Sass variables. And frankly it simplified SO MUCH. It makes theme-switching and color modes much easier to implement without worrying about Sass compile errors or importing things in the right order.

We semi-recently converted Protocol to use custom properties for theming but preserved the Sass variables as fallbacks for older browsers. But looking at support levels and browser usage stats, I've been thinking it's time to embrace the future of CSS and remove those legacy Sass variables (at least for all the theme-level properties; some things can/should remain as Sass variables and mixins).

@craigcook craigcook added the Discussion 🚲 Something we need to discuss label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion 🚲 Something we need to discuss
Projects
None yet
Development

No branches or pull requests

1 participant