-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support variable srcset options for included images? #6
Comments
If we are looking at automating the image resizing for specific components I think we can define a default We can absolutely do this for split.** We'd also benefit from doing it for images that are in the body content (example here) but that would be complicated by which layout theme is applied. No need to do this for SVG images, which in my experience means we don't need to do it for the But also, I spent 18 months not working on Protocol so others may have something more to add ;) |
Thanks @stephaniehobson! Do you thikn we'll end up with one of srcset+size combo per component, or if we can generalize to one/a few? |
The Even if we can't do srcset and sizes automatically we should investigate generating the high-res version of the image automatically... Do you want an explainer on the image sizing stuff? |
Wagtail can downsize and crop to anything we say, so I don't think we'll need to repurpose any Bedrock resizing tooling - does that render an explainer redundant, or do you also mean the what and why of our resizing? I'd happily welcome knowing more about that |
At the moment, when we show an image, we're just showing the original-size image uploaded to Wagtail, but Wagtail can generate image renditions in any res/size we want docs - worth a skim
I wonder whether it would be possible to create a default set of specs as
srcset
for any image block. When we added the Split Block (#5) I temporarily skipped over the srcset option - hence this ticket now.Thoughts are very welcome - particularly from you @craigcook + @stephaniehobson + @alexgibson :
Is there an image size below which
srcset
variations are pointless? (ie, is it silly to try to come up with a one-size-fits srcset list?)Do we need to add
srcset
to any other Protocol components that don't currently mention it in their reference implementation? Would it be pointless or damaging if we did?Do we want to trust Wagtail (well, the very mature Python Pillow library) with auto-sizing images, or would we prefer to make the editors have to upload different image variations themselves, in order to ensure high quality images? (Different orgs have different appetites for both of these routes)
The text was updated successfully, but these errors were encountered: