Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios 上開 https://moztw.org/firefox/ 沒有下載鈕 #708

Open
irvin opened this issue Dec 9, 2022 · 1 comment
Open

ios 上開 https://moztw.org/firefox/ 沒有下載鈕 #708

irvin opened this issue Dec 9, 2022 · 1 comment

Comments

@irvin
Copy link
Member

irvin commented Dec 9, 2022

https://moztw.org/firefox/

inc/dlff-new.html 裏面沒有 iOS 的下載連結
@mingtsay
Copy link
Contributor

在 iOS 上無法正確被辨識

<html class="os-unrecognized">

相關 script 位於 sandstone/js/os_detector.js:23

https://github.com/moztw/www.moztw.org/blob/master/sandstone/js/os_detector.js#L23

        detect: function () {
            os_detector.os_detected = os_detector.get_os();
            switch (os_detector.os_detected) {
            case os_detector.os_list.os_windows:
            case os_detector.os_list.os_windows64:
                return "os-windows";
            case os_detector.os_list.os_linux:
            case os_detector.os_list.os_linux64:
                return "os-linux";
            case os_detector.os_list.os_macosx:
                return "os-macosx os-osx";
            case os_detector.os_list.os_mac:
                return "os-mac";
            case os_detector.os_list.os_android:
                return "os-android os-android-arm";
            case os_detector.os_list.os_android_other:
                return "os-android os-android-other";
            default:
                return "os-unrecognized";
            }
        },

其中遺漏了 os_ios 的判斷，因此跑到 default 那邊去了。

另外，在 inc/dlff-new.html 裡面也無 <li class="os_ios"> ... </li> 的項目，
應該是因為之前 Firefox 在 iOS 商店重新上架後沒有特別加上去，所以這個要另外補一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@irvin @mingtsay