Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possible bug for revealing signed values. #114

Open
fionser opened this issue Sep 14, 2021 · 2 comments
Open

A possible bug for revealing signed values. #114

fionser opened this issue Sep 14, 2021 · 2 comments

Comments

@fionser
Copy link

fionser commented Sep 14, 2021

The revealing function in this line seems not right for converting unsigned value to singed value for Ring with less than 64 bit.

@drunkenlegend
Copy link
Member

Checked it, its correct because to get the signed value, you call getSignedValue after calling reconstruct. Reconstruct is not supposed to return values in 64 bit, but in the bitlength specified.

@fionser
Copy link
Author

fionser commented Mar 10, 2022

But this function returns a signedInt which seems weird if we need extra getSingedValue to convert it to signed values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants