Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero radius bubbles on map #2

Open
gopalkoduri opened this issue Sep 10, 2013 · 5 comments
Open

Zero radius bubbles on map #2

gopalkoduri opened this issue Sep 10, 2013 · 5 comments
Assignees
Labels

Comments

@gopalkoduri
Copy link
Collaborator

Need to get rid of the bubbles which show up despite the artist popularity is zero for that decade/time-period.

@ghost ghost assigned zaen Sep 10, 2013
@zaen
Copy link
Collaborator

zaen commented Sep 13, 2013

I have looked into the source code of jVectorMap, the bubbles (called marker) will be drawn based on two data values:

  • hits for the color of the bubbles
  • listeners for the size of the bubbles

I found several data have zero values for listeners but non-zero for their hits. For those cases of course we will not be able to draw a color for bubbles with zero width.

I still not able to filter the data with zero values of both types yet.

For temporary solution, The label for a zero value (hits/listener) will be hidden.

@mpetyx
Copy link
Owner

mpetyx commented Sep 13, 2013

if you just give no values when it's zero?
so you have totally empty values?
does it work like that?

@zaen
Copy link
Collaborator

zaen commented Sep 13, 2013

Michael, I think I found the bug.

  • There is no problem whenever the zero values are in hits dataset (hits does not affecting the size of the bubble)
  • There is no problem as well whenever the zero values are in listeners dataset (the bubble will be hidden due to zero radius)

The problem occurs whenever the number of items in hits dataset more than items in listeners dataset.
The jVectorMap will be automatically create a dummy bubble to draw the color of hits for each non-exist item in listeners dataset.

I have tried to balance the number of items from both datasets, but on screen a dot still occurs for zero radius. I am thinking to normalize the data.

@mpetyx
Copy link
Owner

mpetyx commented Sep 13, 2013

hm.. this seems quite normal i think.
if you find nothing on that, let me know and i could may normalize it server side

@zaen
Copy link
Collaborator

zaen commented Sep 16, 2013

The jVectorMap has option "normalizeFunction" and "linear" function is applied by default.
I have re-balanced the number of items from both datasets by pushing couple of zeros into the listeners (which are later on will be used as the radius for the bubbles, bubbles with zero radius should be disappear).
It seems to be working on my machine, please test on your machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants