-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard extraction failures do not result in a failure (non-zero) exit code #35
Comments
Thank you for submitting the issue. I will try to fix this in the next few days |
Is there a way to get more info about why these can't sync? Over the last week or two, grafana-sync has produced more of these errors and now most of my dashboards aren't syncing. Is this a matter of a panel that has attributes the code doesn't expect? |
There is issue opened for grafana sdk. But it is not resolved now |
Maybe this would solve it - grafana-tools/sdk#130 |
@mpostument I'm curious - if the goal is to extract the json for backup/restore, why even map it to any data structure other than 'json'/'string'? For now I've switched to CURLing the API to avoid mapping errors. |
@bjhartin I don't have an answer for that, this is how SDK is working. |
I created new version which should return correct status code in case of failure |
When I run:
Some dashboards cannot be retrieved (for which I may raise another issue). See:
The exit code is still 0, however. I had build an automated job to backup the dashboards and it has been 'green' despite these failures because the exit code from grafana-sync was 0. Can this be changed?
The text was updated successfully, but these errors were encountered: