Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloader plugin issues #54

Open
jpd236 opened this issue Dec 25, 2016 · 3 comments · Fixed by #80
Open

Downloader plugin issues #54

jpd236 opened this issue Dec 25, 2016 · 3 comments · Fixed by #80

Comments

@jpd236
Copy link
Contributor

jpd236 commented Dec 25, 2016

Been playing with the downloader (on Mac) and observed the following issues:

  • Download Puzzles window:

    • It's easy to cause Lua errors or even crash the whole app by expanding a source and hovering the mouse over different dates in the calendar quickly.
    • The tooltips flicker when shown.

  • Preferences:

    • Changes to sources never actually seem to persist.
    • Removing a source in the list renders incorrectly (the item above it is copied to the removed area) until you force a redraw (e.g. by scrolling around).
    • "Default disabled" sources from config.lua don't actually seem to be disabled by default.

  • Sources:

    • CrosSynergy is now encrypted and should be removed
    • Newsday importer is broken (failing to read lines from the txt file?)
    • LAT works, although there is a jpz link via the applet that doesn't require a Cruciverb login
    • USA Today has Saturday/Sunday puzzles now too
    • WSJ has an updated link and appears daily
    • Philadelphia Inquirer is defunct; Sunday puzzle is now in Washington Post (by Evan Birnholz).
    • Matt Gaffney's puzzles are all premium and should be removed.
    • Washington Post Puzzler has ended
    • Could add downloader for NYT monthly bonus puzzle

There's probably more, but with it crashing so frequently, I haven't made much use of it yet. Noting what I've found so far here for posterity.
jpd236 added a commit to jpd236/xword that referenced this issue Sep 18, 2019
@jpd236
Make Downloader more stable on Mac.
9c350f2 
Fixes crash when using Show/HideWithEffect and keeps focus on the
downloader window even when a popup is being shown.

Fixes mrichards42#54
jpd236 added a commit to jpd236/xword that referenced this issue Nov 24, 2019
@jpd236
Make Downloader more stable on Mac.
21b7558 
Fixes crash when using Show/HideWithEffect and keeps focus on the
downloader window even when a popup is being shown.

Fixes mrichards42#54
jpd236 added a commit to jpd236/xword that referenced this issue Nov 25, 2019
@jpd236
Make Downloader more stable on Mac.
b984286 
Fixes crash when using Show/HideWithEffect and keeps focus on the
downloader window even when a popup is being shown.

Fixes mrichards42#54
@jpd236 jpd236 mentioned this issue Nov 25, 2019
Merged
jpd236 added a commit to jpd236/xword that referenced this issue Nov 25, 2019
@jpd236
Make Downloader more stable on Mac.
bd5e98a 
Fixes crash when using Show/HideWithEffect and keeps focus on the
downloader window even when a popup is being shown.

Fixes mrichards42#54
jpd236 added a commit to jpd236/xword that referenced this issue Nov 30, 2019
@jpd236
Make Downloader more stable on Mac.
be3b2e6 
Fixes crash when using Show/HideWithEffect and keeps focus on the
downloader window even when a popup is being shown.

Fixes mrichards42#54
jpd236 added a commit to jpd236/xword that referenced this issue Dec 15, 2019
@jpd236
Make Downloader more stable on Mac.
d64088a 
Fixes crash when using Show/HideWithEffect and keeps focus on the
downloader window even when a popup is being shown.

Fixes mrichards42#54
jpd236 added a commit to jpd236/xword that referenced this issue Dec 20, 2019
@jpd236
Make Downloader more stable on Mac.
8322468 
Fixes crash when using Show/HideWithEffect and keeps focus on the
downloader window even when a popup is being shown.

Fixes mrichards42#54
jpd236 added a commit to jpd236/xword that referenced this issue Jan 2, 2020
@jpd236
Make Downloader more stable on Mac.
7399c18 
Fixes crash when using Show/HideWithEffect and keeps focus on the
downloader window even when a popup is being shown.

Fixes mrichards42#54
@jpd236
Copy link
Contributor Author

jpd236 commented Jan 14, 2020

Whoops - this should probably remain open. I fixed the crash/flicker issues, but the preferences/downloader issues are likely still valid.

@mrichards42 mrichards42 reopened this Jan 16, 2020
@mrichards42
Copy link
Owner

Much of this should be fixed now, or at least these:

  • Settings changes should now be fixed (3916da6 and cfca9f0)
  • "Default disabled" sources are respected (b3699be)
  • Sources that no longer publish are removed
  • Broken downloaders are fixed (except NYT, which is disabled by default)

I wasn't able to reproduce this one:

Removing a source in the list renders incorrectly (the item above it is copied to the removed area) until you force a redraw (e.g. by scrolling around).

And this seems to be mostly fixed (as you mentioned), but I was still able to trigger it every once in a while on a Mac:

It's easy to cause Lua errors or even crash the whole app by expanding a source and hovering the mouse over different dates in the calendar quickly.

@jpd236
Copy link
Contributor Author

jpd236 commented Jun 5, 2021

I'm seeing an assertion failure when right clicking on a date:

image

@jpd236 jpd236 mentioned this issue Aug 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Downloader more stable on Mac. jpd236/xword
2 participants
@mrichards42 @jpd236