Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Support playback speed sync (0.75, 1.3, etc.) #8

Open
cratu opened this issue Oct 9, 2022 · 5 comments
Open

Feat: Support playback speed sync (0.75, 1.3, etc.) #8

cratu opened this issue Oct 9, 2022 · 5 comments

Comments

@cratu
Copy link

cratu commented Oct 9, 2022

Problematic

I prefer watch some video with 1.3x speed. When I change playback speen on main window the others plays still with original speed and became sync for short time, when sync_all called.

Solution

With checking state check check also playback speed and sync with others copies. Does RC API support that functions, I don't know.

@mrkeuz
Copy link
Owner

mrkeuz commented Oct 11, 2022

Hi, thanks for report.

Yes. I'm also thinking about changing playback speed.

It is quite tricking for implement. Without breaking the main functionality.
Without tests, it's just a big waste of time in the testing phase (see #6 description)

Just I need a lot of time for testing all use cases.

So I will add this task some when after #6
From codebase POV It's quite simple feature, if RC API returns speed rate.

So be patient! I'll definitely come back to this issue in the future (after #6).

@mrkeuz mrkeuz changed the title Feat: playback speen sync Feat: support playback speed support (0.75, 1.3, etc.) Oct 11, 2022
@cratu
Copy link
Author

cratu commented Oct 21, 2022

Doubled "support" in the name of feature.

@mrkeuz mrkeuz changed the title Feat: support playback speed support (0.75, 1.3, etc.) Feat: Support playback speed sync (0.75, 1.3, etc.) Oct 22, 2022
@mrkeuz
Copy link
Owner

mrkeuz commented Oct 22, 2022

@cratu, Thanks! Fixed.

@mrkeuz
Copy link
Owner

mrkeuz commented Oct 22, 2022

Just FYI, already started working on #6, so next features will release out faster

@mrkeuz
Copy link
Owner

mrkeuz commented Jun 18, 2023

Little update, I'm almost done feature. I had to change the "main" sync algorithm for this. But still there are bugs in corner cases (cannot reproduce yet stable without unit testing #6).

Will prepare alpha version soon just for ability use as-is for those who are waiting and for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants