Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseVersion does not recognize Synology package versions correctly #245

Open
zanglang opened this issue Nov 14, 2018 · 1 comment · May be fixed by #247
Open

parseVersion does not recognize Synology package versions correctly #245

zanglang opened this issue Nov 14, 2018 · 1 comment · May be fixed by #247

Comments

@zanglang
Copy link

Seems that Synology packages use a slightly different naming strategy that simply cut -f2 -d_ is incorrect.

Retrieving list of available distributions
RELEASE="label":"Intel - 64-bit (DSM 6.0 or newer)","build":"linux-ubuntu-x86_64","distro":"synology","url":"https://downloads.plex.tv/plex-media-server/1.13.9.5456-ecd600442/PlexMediaServer-1.13.9.5456-ecd600442-x86_64.spk","checksum":"94df1233c217d0a0e13d892eba51a5caa999d7d0"
DOWNLOAD=https://downloads.plex.tv/plex-media-server/1.13.9.5456-ecd600442/PlexMediaServer-1.13.9.5456-ecd600442-x86_64.spk
CHECKSUM=94df1233c217d0a0e13d892eba51a5caa999d7d0
WARNING: Unable to detect installed version, first time?
INSTALLED_VERSION=
FILE_VERSION=64.spk
File already exists (PlexMediaServer-1.13.9.5456-ecd600442-x86_64.spk), won't download.

Whilst version checking isn't really used for non standard Linux OS builds, I think parseVersion could be modified to tokenize the version strings by - or _ first, and then looking for a token that matches /([0-9]+.?)+/ instead.
@myellen myellen linked a pull request Nov 28, 2018 that will close this issue
Open
@bruvv
Copy link

bruvv commented Apr 16, 2019

#259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update plex-core to support synology packages myellen/plexupdate
2 participants
@zanglang @bruvv