Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change :: [ Function] in your popup menu -> Please READ #173

Open
ms-jpq opened this issue Aug 31, 2021 · 17 comments
Open

Breaking change :: [ Function] in your popup menu -> Please READ #173

ms-jpq opened this issue Aug 31, 2021 · 17 comments
Labels
documentation Improvements or additions to documentation

Comments

@ms-jpq
Copy link
Owner

ms-jpq commented Aug 31, 2021

If you see

图片


Solution

Either set let g:coq_settings = { 'display.icons.mode': 'none' } to disable icons, or install a supported font.

@ms-jpq ms-jpq added the documentation Improvements or additions to documentation label Aug 31, 2021
@ms-jpq ms-jpq pinned this issue Aug 31, 2021
Repository owner locked and limited conversation to collaborators Aug 31, 2021
Repository owner unlocked this conversation Aug 31, 2021
@ms-jpq
Copy link
Owner Author

ms-jpq commented Aug 31, 2021

I added Icon support, and decided to try my luck turning it on by default.

🐸


If you turn off the icon support, it goes back to same as before, and if you install the fonts:

icons.png

@ms-jpq ms-jpq changed the title [ Function] in your popup menu -> Pleeas READ Breaking change :: [ Function] in your popup menu -> Pleeas READ Aug 31, 2021
@ms-jpq ms-jpq changed the title Breaking change :: [ Function] in your popup menu -> Pleeas READ Breaking change :: [ Function] in your popup menu -> Please READ Aug 31, 2021
@beauwilliams
Copy link

beauwilliams commented Sep 2, 2021

I am seeing this issue here. We need a space after the icons for when no subtext to it's not juxtaposed next to the ]

image

@ms-jpq
Copy link
Owner Author

ms-jpq commented Sep 2, 2021

EDITED:


coq_settings.display.icons.spacing

How many of padding to use after icon.

Increase this if your icons are too close to each other.

default:

1

@beauwilliams
Copy link

@beauwilliams please set coq_settings.display.pum.kind_context to [" [", " ]"], or whatever you want it to be.

I think like for different fonts, the spacing is different? so its probably easier to adjust the brackets than all the icons.

edit: the default is [" [", "]"], missing the space

Sure thing, thanks for the help and I can add that in no drama.

Should we change the default however?

@ms-jpq
Copy link
Owner Author

ms-jpq commented Sep 2, 2021

wait i had a brain fart, sorry what i said cannot fix it for you, its in the wrong direction, derp.

ill make a pr to fix it for u

@ms-jpq
Copy link
Owner Author

ms-jpq commented Sep 2, 2021

#198


coq_settings.display.icons.spacing

How many of padding to use after icon.

Increase this if your icons are too close to each other.

default:

1

@beauwilliams
Copy link

Good news is the new option works. But it seems I still have the same issue for the BUF type

error

@beauwilliams
Copy link

beauwilliams commented Sep 2, 2021

If we don't ever have anything but text for the buffer completion type. We could just have it say [aA Text] like the lsp completion at the top there, or add a space when nothing is returned next to the icon

@ms-jpq
Copy link
Owner Author

ms-jpq commented Sep 2, 2021

sorry please try it now.

@beauwilliams
Copy link

yep its fixed with latest pull if I set spacing to 2 👍

@elkowar
Copy link

elkowar commented Sep 11, 2021

is it possible to only show the icon, and hide the text description? the redundancy is kind of unnecessary

@ms-jpq
Copy link
Owner Author

ms-jpq commented Sep 12, 2021

@ms-jpq
Copy link
Owner Author

ms-jpq commented Sep 12, 2021

coq_settings.display.icons.mode -> short

@matheusAMDS
Copy link

I'm trying the option let g:coq_settings = { 'display.icons.mode': 'none' } but it's not working.

@mkubasz
Copy link

mkubasz commented Oct 14, 2021

@ms-jpq Short is buggy too. I'm using nerd fonts.

@mkubasz
Copy link

mkubasz commented Oct 14, 2021

This is my solution
display = { icons = { mappings = { Text = "", Method = "", Function = "", Constructor = "", Field = "ﰠ", Variable = "", Class = "ﴯ", Interface = "", Module = "", Property = "ﰠ", Unit = "塞", Value = "", Enum = "", Keyword = "", Snippet = "", Color = "", File = "", Reference = "", Folder = "", EnumMember = "", Constant = "", Struct = "פּ", Event = "", Operator = "", TypeParameter = "" } } }

@maxwelljens
Copy link

maxwelljens commented Feb 5, 2022

let g:coq_settings = { 'display.icons.mode': 'none' } seems to have no effect for me either. I still see icons. I call it before calling require('coq'). The plugin otherwise works perfectly.

Edit: I gathered from #292 that adding the following to the Lua configuration, before require('coq'), works:

vim.g.coq_settings = {
  display = { icons = { mode = 'none'} }
}

I no longer see icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants