Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolutely LOVE the code, great job! Help with RFC-2250 #1

Open
g00dnatur3 opened this issue Feb 17, 2017 · 2 comments
Open

Absolutely LOVE the code, great job! Help with RFC-2250 #1

g00dnatur3 opened this issue Feb 17, 2017 · 2 comments

Comments

@g00dnatur3
Copy link

g00dnatur3 commented Feb 17, 2017

This code is super readable, to the point, and encapsulated perfectly..

The whole implementation is just an object with getters and setters...

sender uses setters, receiver uses getters & the constructor --

so i literally just read the datagram from the socket and throw it to the constructor...

AWESOME..

But my question is, what changes would I need to make to support rfc-2250.

Which getters and setters would need to change to support 2250?

Thanks!!

@g00dnatur3 g00dnatur3 changed the title Assolutely LOVE the code, great job! Help with RFC-2250 Absolutely LOVE the code, great job! Help with RFC-2250 Feb 17, 2017
@mscdex
Copy link
Owner

mscdex commented Feb 17, 2017

Honestly, when I originally wrote this 6.5 years ago, it was more of a proof-of-concept to be able to send/receive RTP audio packets in node rather than be a real full-fledged module. With that in mind, I don't have any plans to make any changes to this code. There are probably more complete modules available on npm these days.

@1995parham
Copy link

@g00dnatur3 I tried to create new RTP module for NodeJS based on RFC3550. If you want you can check it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants