Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should bbrun set environment Variable CI=true #13

Open
busch-matthias opened this issue Mar 19, 2018 · 4 comments
Open

Should bbrun set environment Variable CI=true #13

busch-matthias opened this issue Mar 19, 2018 · 4 comments

Comments

@busch-matthias
Copy link

I think Bitbucket use the environment Variable "CI" to indicate that the script is running on a pipeline.
Should bbrun automatically set CI to "true" ?

@mserranom
Copy link
Owner

I don't think so, this variable is normally used to tell whether we're executing the build scripts in the actual CI environment or in our local machines.

To emulate the CI environment we can always execute bbrun with --env CI=true

@airtonix
Copy link

Yes it should. the point of this tool is to simulate bitbucket pipelines.

@mserranom mserranom reopened this Jul 12, 2018
@mserranom
Copy link
Owner

Reopening for discussion. Will reevaluate based on what other CLI tools are doing (circlecli CLI, travis CLI, etc...)

@ndastur
Copy link

ndastur commented Oct 10, 2018

Just my 2cents. But I think as an emulator of the bitbucket pipeline it should. I for instance use the presence of this variable to set up the testing environment. I agree --env CI=true could be used but that represents poor discoverability and doesn't seem to do what is in the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants