-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Svelte 5] Deprecations/warnings #249
Comments
Made the first steps in a separate branch. Unfortunately I'm unable to push the branch to this repo. Currently stuck on another dependency that's also a bit behind, I'll go over there and try to fix the problem, so svelecte can go ahead with the most recent svelte 5 version!
Small update already: |
Normal workflow is you fork the repo, submit changes to your branch (master or another), then create pull request. I am not sure, it's required for tiny-virtual-list to be also on svelte 5.
I tried to update to the latest version of svelte 5 during the weekend, but tests were failing and I really wasn't in the mood of finding why. If you e2e tests are failing maybe you could relax some rules to allow warnings? |
Also I hope we are talking about |
Alright! Then I'm gonna make a fork when I notice svelte-tiny-virtual-list is compatible with svelte 5! We work with webpack, and things seem to be a bit gimmicky with warnings and errors. It compiles correctly, shows everything when you look at the served page, but when running tests it doesn't wanna show it anymore with warnings for some reason. Currently looking into it why, but it's really irritating that some things just don't work with testing, while it works when you're looking at the served page :( |
This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
Hi there!
While installing and using svelecte, I noticed there are some warnings while compiling this package, which unfortunately break our end2end tests.
Warnings of Svelecte that are present:
To take some work off your shoulders, so you can focus on improving svelecte overall, I'm going to try and fix those warnings for you if you want.
Don't hesitate to share thoughts!
The text was updated successfully, but these errors were encountered: