Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add removeIndex to SingleSlotMapper #97

Open
naddison36 opened this issue Dec 6, 2022 · 0 comments
Open

Add removeIndex to SingleSlotMapper #97

naddison36 opened this issue Dec 6, 2022 · 0 comments
Labels
contract Contract work v2 mStable v2 roadmap

Comments

@naddison36
Copy link
Contributor

SameAssetUnderlyingsAbstractVault.removeVault currently calls SingleSlotMapper.removeValue with the removedValue parameter being the index of the _activeUnderlyingVaults array.

It would be more gas efficient if SameAssetUnderlyingsAbstractVault.removeVault called a new SingleSlotMapper.removeIndex function padding in the vaultIndex that is passed to the SameAssetUnderlyingsAbstractVault.removeVault function.
@naddison36 naddison36 added contract Contract work v2 mStable v2 roadmap labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contract Contract work v2 mStable v2 roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naddison36