Oracle Driver porting or adding #785
Replies: 8 comments 8 replies
-
We need a dev for that. The maintainer the oracle driver reported to be busy. |
Beta Was this translation helpful? Give feedback.
-
I'll convert this to a discussion since it won't be worked in this repository, but the discussion still have room to grow here |
Beta Was this translation helpful? Give feedback.
-
Any updates on this? I would like to contribute but I couldn't find the old driver to get it ported so can someone point to the right direction? |
Beta Was this translation helpful? Give feedback.
-
They are in previous version: https://github.com/mtxr/vscode-sqltools/tree/v0.21.9/packages/core/dialect/oracle . I have tried to port it myself at some point, but since then I went to using dbeaver OSS. |
Beta Was this translation helpful? Give feedback.
-
Hey @mtxr @george-james-software @gjsjohnmurray, I'm trying to do the Oracle porting and I noticed that when u click the button "Test Connection" and the driver's extra dependencies are not installed (sqlite or oracledb for example) then it just fails, showing something like: So if you haven't had installed already oracledb (in this case) then the button "Test Connection" will always fail. It would be nice if the dependency installation occurred similarly than with the button "Connect Now", otherwise for new people who install this extension for the first time the "Test Connection" button is always gonna fail unless they click on "Save Connection" and then "Connect now" first so sqltools will ask to install the dependencies. (sqlite it's just a matter of showing the example) I tried to make the method public async testConnection(): Promise<void> {
await this.checkDependencies(); // I thought this line was the solution but this method only gets executed if the dependencies are already installed
await this.open();
...some logic...
await this.close();
} |
Beta Was this translation helpful? Give feedback.
-
Hi What you describe sounds like a bug. If you add it as an issue then we can investigate and see what's going on. George |
Beta Was this translation helpful? Give feedback.
-
Much appreciate if this can be added as vs code is my all in one solution for daily tasks. |
Beta Was this translation helpful? Give feedback.
-
I'm also woking on it right now and am still doing some tests and may have some issues. The project is at https://github.com/hashhashu/sqltools-Oracle-driver. |
Beta Was this translation helpful? Give feedback.
-
Any updates or roadmap for Oracle Driver porting or adding on last version?
Thanks in advance.
Beta Was this translation helpful? Give feedback.
All reactions