Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result Tab - Duplicating keyboard shortcut commands #1364

Open
shabaz-dbx opened this issue Aug 7, 2024 · 0 comments
Open

Result Tab - Duplicating keyboard shortcut commands #1364

shabaz-dbx opened this issue Aug 7, 2024 · 0 comments
Labels

Comments

@shabaz-dbx
Copy link

Describe the bug
When multiple result tabs are open, window interaction keyboard shortcut commands seem to be "duplicated". It seems that one shortcut command is activated twice, resulting in a different behavior. Specifically, if there are multiple result tabs open, and i execute the CMD+W command to close the current tab, more than one tab ends up being closed often times. Additionally, if there are multiple result tabs open, and I execute CMD+ALT+Right Arrow, or CMD+ALT+Left Arrow, to navigate to the next or previous tab, often times it will skip over a tab, almost appearing that the command was registered twice.

To note, this behavior ONLY exist on the SQL Tools result tabs, on any other files open within the editor, these commands work as expected.

To Reproduce
Steps to reproduce the behavior for CLOSE TAB:

  1. Have multiple SQL Tools Result tabs open
  2. Ensure that your current tab is a SQL Tools Result tab
  3. Use the CMD+W keyboard shortcut to close the current tab
    WRONG Behavior: more than one tab will be closed

Steps to reproduce the behavior NAVIGATE NEXT TAB:

  1. Have multiple SQL Tools Result tabs open
  2. Ensure that your current tab is a SQL Tools Result tab, and the next tabs (tabs that are to the right) are also SQL Tools Result tab
  3. Use the CMD+ALT+Right Arrow keyboard shortcut to navigate to the next tab
    WRONG Behavior: it will navigate to the next tab, and then navigate to the next tab again, thus moving TWO tabs to the right

Steps to reproduce the behavior NAVIGATE PREVIOUS TAB:

  1. Have multiple SQL Tools Result tabs open
  2. Ensure that your current tab is a SQL Tools Result tab, and the previous tabs (tabs that are to the left) are also SQL Tools Result tab
  3. Use the CMD+ALT+Left Arrow keyboard shortcut to navigate to the previous tab
    WRONG Behavior: it will navigate to the previous tab, and then navigate to the previous tab again, thus moving TWO tabs to the left

Expected behavior
Close window: should only close ONE tab (not more than one)
Navigate next tab: should only navigate ONE tab to the right
Navigate prev tab: should only navigate ONE tab to the left

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • SQLTools Version: v0.28.3
  • VS Code Version: 1.92.0
  • OS: Mac
  • Driver: Databricks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant