Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callout bubble in dark mode should have a dark background #8

Open
muffix opened this issue Dec 30, 2022 · 0 comments
Open

Callout bubble in dark mode should have a dark background #8

muffix opened this issue Dec 30, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed iOS Affects iOS

Comments

@muffix
Copy link
Owner

muffix commented Dec 30, 2022

Is your feature request related to a problem? Please Describe.

The bubble background should be dark, but is actually light.

Despite allowing arbitrary views, the callout bubble that drawn by react-native-maps does not seem to allow for a customisation of the border colour. It remains white even in dark mode. We can make the background dark, but it doesn't look right with a white border.

Describe the solution you'd like

Ideally, react-native-maps would allow us to customise the border colour.

Alternatively, we can completely replace the bubble with a custom view by setting the tooltip prop. This allows for completely custom views, including self-drawn bubbles.

Describe alternatives you've considered

Apply the (presumed to be) correct styling to the callout, but the border remains white.
Additional context

It seems that the colour is hard-coded and cannot be overridden in React: https://github.com/react-native-maps/react-native-maps/blob/c447dea5eb4551440b131e3003ac50e0c5709fa9/ios/AirMaps/Callout/SMCalloutView.m#L607

@muffix muffix added enhancement New feature or request help wanted Extra attention is needed iOS Affects iOS labels Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed iOS Affects iOS
Projects
None yet
Development

No branches or pull requests

1 participant