Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Water Drop icon is missing #33204

Closed
2 tasks done
anthonysapien opened this issue Jun 18, 2022 · 11 comments · Fixed by #36608
Closed
2 tasks done

[icons] Water Drop icon is missing #33204

anthonysapien opened this issue Jun 18, 2022 · 11 comments · Fixed by #36608
Assignees
Labels
new feature New feature or request package: icons Specific to @mui/icons

Comments

@anthonysapien
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

For some reason, the water drop material icon is missing from the set.

Can't resolve '@mui/icons-material/WaterDropRounded'

Expected behavior 🤔

This icon should be included.

Steps to reproduce 🕹

Steps:

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@anthonysapien anthonysapien added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 18, 2022
@kyrylolvov
Copy link

@anthonysapien Are you sure you are looking for an existing icon?

@mnajdova mnajdova self-assigned this Jun 20, 2022
@mnajdova
Copy link
Member

This icon didn't exists in v4 and it don't exists in v5. Here are some alternatives you can use - https://mui.com/material-ui/material-icons/?query=water+drop

@mnajdova mnajdova added component: Icon The React component. status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 20, 2022
@anthonysapien
Copy link
Author

@anthonysapien
Copy link
Author

I see it's part of something called Material Symbols vs. Material Icons.

@anthonysapien
Copy link
Author

@anthonysapien
Copy link
Author

@mnajdova Hi, can you please reopen this issue or help me to understand the approach? The water drop icon is part of the material icon set. Isn't MUI trying to include all of the icons?

@mnajdova
Copy link
Member

We haven't migrated to Material Symbols yet. See #32846 for more info

@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists package: icons Specific to @mui/icons and removed status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it component: Icon The React component. labels Sep 6, 2022
@anthonysapien
Copy link
Author

Hi. This icon is now part of the Material Icons set. Can it be included in the MUI set as well?
https://fonts.google.com/icons?icon.query=water+drop&icon.set=Material+Icons

@mnajdova mnajdova assigned michaldudak and unassigned mnajdova Mar 14, 2023
@michaldudak michaldudak removed the duplicate This issue or pull request already exists label Mar 14, 2023
@michaldudak michaldudak changed the title Water Drop icon is missing [icons] Water Drop icon is missing Mar 14, 2023
@michaldudak
Copy link
Member

michaldudak commented Mar 14, 2023

@oliviertassinari The 'water_drop' icon is explicitly excluded in the ignoredIconNames in our download script.

const ignoredIconNames = new Set([

Do you have any idea why? cc @eps1lon as the author of this change (940ce13#diff-e3d08bc3f8775e71887746b6836901b21d9a681c078c5fd4771f2178ae878fa2).

@michaldudak michaldudak reopened this Mar 14, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 19, 2023

@michaldudak I don't know why this icon is here. However, in the past, we used the popularity property from https://fonts.google.com/metadata/icons to prune icons, maybe it was related. That many icons stress test npm, bundlers, etc.

No objections to add this icon.

@eps1lon
Copy link
Member

eps1lon commented Mar 20, 2023

Do you have any idea why? cc @eps1lon as the author of this change (940ce13#diff-e3d08bc3f8775e71887746b6836901b21d9a681c078c5fd4771f2178ae878fa2).

See commit message "Ignore newly introduced icons" and Oliviers explainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants