Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][Select] placeholder prop is omitted #44821

Open
thany opened this issue Dec 20, 2024 · 1 comment · May be fixed by #44856
Open

[docs][Select] placeholder prop is omitted #44821

thany opened this issue Dec 20, 2024 · 1 comment · May be fixed by #44856
Assignees
@aarongarciah
Labels
ready to take Help wanted. Guidance available. There is a high chance the change will be accepted status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page

Comments

@thany
Copy link

thany commented Dec 20, 2024 •
edited by github-actions bot
Loading

Related page

https://mui.com/material-ui/api/select/

Kind of issue

Missing information

Issue description

Following issue #44502, the placeholder prop has been removed from the Select component for having no effect. While I'm inclined to disagree (MUI could render a placeholder, and the Select documentation event suggests on how to render one) the API documentation should at least reflect that decision.

As of the time of writing, the Select API documentation makes no mention of the omission of the placeholder prop. In fact, it refers to OutlinedInput:

Props of the OutlinedInput component are also available.

Which is where it is rightfully listed, leading developers to believe it should be available in Select.

I was ready to file a bug report, but having found that issue, I discovered placeholder was omitted intentionally. At first I went to the documentation to figure out what's what with this prop, but no mention of it was made, which lead me to create the issue you're reading now.

Context

No response

Search keywords: select placeholder
@thany thany added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Dec 20, 2024
@aarongarciah
Copy link
Member

@thany thanks for reporting! We should update the docs to reflect this.

@aarongarciah aarongarciah changed the title [docs] Select placeholder prop is omitted [docs][Select] placeholder prop is omitted Dec 24, 2024
@aarongarciah aarongarciah added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Dec 24, 2024
@adityaparab adityaparab linked a pull request Dec 25, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarongarciah aarongarciah

Labels
ready to take Help wanted. Guidance available. There is a high chance the change will be accepted status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs][Select] Update docs to reflect the omission of placeholder prop adityaparab/material-ui
2 participants
@thany @aarongarciah