-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Remove dependency on Material UI #12219
Comments
This would be really nice for Joy UI users, since they are basically in the MUI ecosystem but cannot use MUI X anyways. This would unlock the charts part at least, which is a great step towards decoupling everything from Material UI. |
@Fabb111 Yes, moving to a Pigment CSS dependency, where all the theming logic would move. We might even:
|
Sounds great. And especially the second option sounds like the perfect long term goal since it would improve the overall adaptability. But I guess this issues goal is a more short- to midterm "quick fix", right? Just for my personal knowledge, do you have a rough timeline for this? Since it's probably not straight forward I expect it would take longer for this to arrive, right? |
For sure, we will do this by step. The team working on the charts's main concern is growing the charts in the React ecosystem, so to fit well with other UI libraries, Shadcn, Mantine, etc. and of course, with the other MUI open source projects. |
Summary
This charts library has a dependency on Material UI and Emotion https://unpkg.com/browse/@mui/[email protected]/package.json
which discredit it as a viable alternative to Recharts if you are not already in the MUI ecosystem.
Examples
Once we fix mui/material-ui#40594 we should able to only have a dependency on MUI System/Pigment CSS, which is equivalent to adazzle/react-data-grid#3407.
This issue is potentially a duplicate of #11123. But not necessarily, we could see this one as the extension of mui/material-ui#40594 in MUI X.
Motivation
See:
https://ably.com/blog/top-react-chart-libraries#mui-x-charts.
It sounds about right. No engineers in their right mind should add MUI X Charts as a dependency unless they already use Emotion.
Search keywords: Material UI dependency
The text was updated successfully, but these errors were encountered: