Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DashboardLayout] No CSS transitions in persistent sidebar under certain screen width #4505

Open
apedroferreira opened this issue Dec 3, 2024 · 1 comment · May be fixed by #4522
Open

[DashboardLayout] No CSS transitions in persistent sidebar under certain screen width #4505

apedroferreira opened this issue Dec 3, 2024 · 1 comment · May be fixed by #4522
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@apedroferreira
Copy link
Member

apedroferreira commented Dec 3, 2024 •
edited by github-actions bot
Loading

I'm looking at

toolpad/packages/toolpad-core/src/DashboardLayout/DashboardLayout.tsx

Line 251 in 1561c23

const hasDrawerTransitions =

and at

toolpad/packages/toolpad-core/src/DashboardLayout/DashboardSidebarSubNavigation.tsx

Line 124 in 1561c23

...(hasDrawerTransitions

and I'm wondering if there's a specific reason why transitions are disabled on small viewports?

It feels a bit odd when the sidenav transitions smoothly when opening but the sub-header just snap.

Screen.Recording.2024-12-03.at.21.58.12.mov

Originally posted by @rolandjitsu in #4503

Search keywords:
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 3, 2024
@apedroferreira apedroferreira changed the title I'm looking at [DashboardLayout] No CSS transitions in persistent sidebar under certain screen width Dec 3, 2024
@apedroferreira apedroferreira added bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 3, 2024
@apedroferreira
Copy link
Member Author

The original intention was to disable the CSS transitions only for the temporary sidebar that shows on mobile devices, but there's a bug as it can also show on the persistent sidebar.
The proposed solution is to change the logic for the hasDrawerTransitions variable so that this behavior works as originally intended.

@gil-obradors gil-obradors linked a pull request Dec 8, 2024 that will close this issue
Open
4 tasks
@prakhargupta1 prakhargupta1 moved this from Backlog to In progress in MUI Toolpad public roadmap Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process.
Projects
MUI Toolpad public roadmap
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DashboardLayout] Fix sidebar CSS transitions for some breakpoints gil-obradors/toolpad
1 participant
@apedroferreira