Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multistream-select v1 does not handle timeouts #47

Open
raulk opened this issue Nov 1, 2019 · 0 comments · May be fixed by #48
Open

multistream-select v1 does not handle timeouts #47

raulk opened this issue Nov 1, 2019 · 0 comments · May be fixed by #48

Comments

@raulk
Copy link
Member

raulk commented Nov 1, 2019 •
edited
Loading

See filecoin-project/lotus#518.

Proposed solution is to set deadlines on the underlying I/O object.
raulk added a commit that referenced this issue Nov 1, 2019
@raulk
handle timeouts using i/o deadlines.
21fd290 
Both initiator and responder now time out if reads
and/or writes are blocked for 30 seconds (default
negotiation timeout).

Introduces two tests to validate the new behaviour.

Fixes #47.
@raulk raulk linked a pull request Nov 1, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle timeouts using i/o deadlines. multiformats/go-multistream
1 participant
@raulk