Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: identity hash doesn't export proper type of Hasher<Name, Code> #313

Open
SgtPooki opened this issue Dec 2, 2024 · 0 comments · May be fixed by #314
Open

bug: identity hash doesn't export proper type of Hasher<Name, Code> #313

SgtPooki opened this issue Dec 2, 2024 · 0 comments · May be fixed by #314
Assignees
@SgtPooki
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@SgtPooki
Copy link

SgtPooki commented Dec 2, 2024 •
edited
Loading

js-multiformats/src/hashes/identity.ts

Line 13 in 75712e7

export const identity = { code, name, encode, digest }

discovered when working on ipfs/ipld-explorer-components#465
@SgtPooki SgtPooki added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue good first issue Good issue for new contributors status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours labels Dec 2, 2024
@SgtPooki SgtPooki linked a pull request Dec 2, 2024 that will close this issue
Open
@SgtPooki SgtPooki linked a pull request Dec 2, 2024 that will close this issue
fix!: identity hash is Hasher<"identity", 0> #314
Open
@SgtPooki SgtPooki self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: identity hash is Hasher<"identity", 0> multiformats/js-multiformats
1 participant
@SgtPooki