Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: /transaction/<hash> should return additional useful fields #103

Open
hiddentao opened this issue Nov 3, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@hiddentao
Copy link

hiddentao commented Nov 3, 2020

The proxy /transaction/<hash> endpoint should additionally return:

  • The date timestamp
  • The gasUsed value
  • The transaction hash (this may seem redundant but is actually useful for when passing the returned object around)
  • The transaction status field should reflect the actual transaction execution result, i.e passed or failed. In addition to this the error message should be available somewhere (e.g. "not enough gas")
@hiddentao hiddentao changed the title Feature Request: /transaction/<hash> should return date timestamp as well as gasUsed Feature Request: /transaction/<hash> should return additional useful fields Nov 3, 2020
@andreibancioiu andreibancioiu added the enhancement New feature or request label Nov 23, 2020
@miiu96
Copy link
Contributor

miiu96 commented Nov 24, 2020

These fields that you have mentioned will be added soon in the API transaction structure.
Thank you for the feedback. We really appreciate.

@miiu96
Copy link
Contributor

miiu96 commented Nov 24, 2020

A part of the information that you need will be merged very soon in the proxy development branch (#104). Hope this will help.

@ImPedro29
Copy link

Hey :), my company is implementing elrond and we did not getting to implement of gasUsed of the transaction, you have a prediction for this implementation?

@bogdan-rosianu
Copy link
Contributor

bogdan-rosianu commented Oct 19, 2021

Hi @hiddentao @ImPedro29 !
As an update for this issue:

  • the timestamp field has been added
  • the status resembles the expected value if the endpoint is called with ?withResults=true . Also, smart contract results or receipts with the failing messages are shown as well.

The gasUsed and hash fields have not been added. If we'll add them in the future, I will leave a comment on this issue.

@vae520283995
Copy link

@bogdan-rosianu Hi, no plans to add gasUsed and fee fields yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants