Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motor testing can cause unintentional launch on later disarm. #5

Open
nmw opened this issue Sep 22, 2015 · 0 comments
Open

motor testing can cause unintentional launch on later disarm. #5

nmw opened this issue Sep 22, 2015 · 0 comments

Comments

@nmw
Copy link

nmw commented Sep 22, 2015

the "If (motors_running) enable test mode" part on your motor test page puts things in a dangerous state, because the MSP_SET_MOTOR currently in baseflight updates the disarmed motor speeds, which has no immediate effect (so adjusting them doesn't work in configurator anyway, until you disarm).

When you disarm, it jumps to whatever speeds were set using MSP_SET_MOTOR, which can happen even after leaving that screen and/or disconnecting.

I've made some fixes to baseflight, which mostly prevent this from happening, but as you currently need to disarm before doing motor testing anyway, it probably makes most sense to just remove that, or better yet, disallow checking the box when armed (to avoid the potential jump at disarm). Also setting values to minimum when checking the box is probably not a bad idea either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant