Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase client-side max bitrate #5989

Open
Patrick12300 opened this issue Dec 13, 2022 · 6 comments · May be fixed by #5994
Open

Increase client-side max bitrate #5989

Patrick12300 opened this issue Dec 13, 2022 · 6 comments · May be fixed by #5994
Labels
client feature-request This issue or PR deals with a new feature

Comments

@Patrick12300
Copy link

Description

The bitrate in the Registry and in the client gets overwritten after applying new settings in the options.

Steps to reproduce

close mumble
setting to a higher bitrate then the settings allowed: HKEY_CURRENT_USER\Software\Mumble\Mumble\audio - quality to
e.g. 529000
close regedit and start mumble
verify with the audio statistics
go to the options with or without changing somethings and click apply or ok
in the audio statistics is now the value that was in the settings e.g. 192000
close mumble and open regedit
the value in the registry is now changed too

Mumble version

1.4.287

Mumble component

Client

OS

Windows

Reproducible?

Yes

Additional information

Additional question: Why do I have only 300kbit/s in the audio statistics after setting the value to 529000?

Relevant log output

<W>2022-12-13 15:03:04.969 AudioInput: 529000 bits/s, 48000 hz, 480 sample
After clicking OK/Apply:
<W>2022-12-13 15:03:11.132 AudioInput: 192000 bits/s, 48000 hz, 480 sample

Screenshots

No response
@Patrick12300 Patrick12300 added bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels Dec 13, 2022
@Krzmbrzl
Copy link
Member

setting to a higher bitrate then the settings allowed

where is it stated that this is even a valid thing to do (not trying to be condescending here - just interested in the answer as that might influence how to proceed with this issue)?

@Patrick12300
Copy link
Author

#3753
https://github.com/mumble-voip/mumble/pull/4700/files#diff-9aaa7f5993ff7c40c949705c6c672929567b3023f3da411b6c6717ecf9485ec0

As I understand you changed the range to 558kbit/s in murmur (#4700) but didn't changed the slider in mumble:
"I thought about that. But maybe the bar would be ugly and harder to use? I also thought about an idea to enable up to 510kbit/s in the UI only if "Advanced" option is checked, and use 96 or 192kbit/s as maximum otherwise."

The problem is that murmur allows 558kbit/s but mumble not (in the UI) for some reason. The other problem is that even if you change the value to 529 in the registry, it goes only up to 300kbit/s (330 with overhead).

One of the simple solution for now is to apply the value of the slider only if the value is at or below 192000. Otherwise it remains untouched because it was changed manually or to change the slider to 300kbit/s because discord allows it too but for 60€/per month and mumble is the only costless alternative and the reason I changed. For the 300kbit/s problem I have no solution.

@Krzmbrzl
Copy link
Member

The problem is that murmur allows 558kbit/s but mumble not (in the UI) for some reason.

The reason essentially is that we deemed it to be unnecessary (and that it would probably require a UI change to make it usable). The limit was bumped in order for music bots to be able to stream at higher bitrates.

So from what you have linked, I take it that it is actually never stated that increasing the bitrate setting beyond what is possible from the UI is a valid operation.
Therefore, this will not be fixed.

The suggestion you made would be simple enough, but it would also introduce complexity into the code base that (effectively) is not necessary.

@davidebeatrici
Copy link
Member

Consider that we would like to avoid touching our current Opus implementation, as we're eventually going to switch to the one provided by libmumble.

@Krzmbrzl
Copy link
Member

This doesn't do anything with the Opus implementation - this is only related to our UI (as far as I understand)

@Krzmbrzl Krzmbrzl added client feature-request This issue or PR deals with a new feature and removed needs-more-input bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels Dec 26, 2022
@Krzmbrzl Krzmbrzl changed the title Mumble custom Bitrate resets after applying new settings Increase client-side max bitrate Dec 26, 2022
Krzmbrzl added a commit to Krzmbrzl/mumble that referenced this issue Dec 26, 2022
@Krzmbrzl
FEAT(client, ui): Allow for max bitrate in client
cd5fa38 
Via mumble-voip#4700, the server binaries were adapted to allow for an Opus bitrate
of up to 510000 bits per second. The client on the other hand was left
at a max of 192 kb/s.

While this should be more than sufficient for most users, we now adapt
the limit on the client side to (in theory) be able to encode packages
with that 510 kb/s bitrate limit. Outside of very specialized
applications, this should be avoided though.

In order to keep the UI manageable, the respective slider now uses a
logarithmic scale. This also has the benefit that optically, the default
value of 40 kb/s looks pretty good compared to the max. possible value
and therefore novice users hopefully keep that value at its default.

Fixes mumble-voip#5989
@Krzmbrzl Krzmbrzl linked a pull request Dec 26, 2022 that will close this issue
Draft
1 task
@Krzmbrzl
Copy link
Member

This should be fixed via #5994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client feature-request This issue or PR deals with a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEAT(client, ui): Allow for max bitrate in client Krzmbrzl/mumble
3 participants
@davidebeatrici @Krzmbrzl @Patrick12300