-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W10] Settings doesn't stick on restart #6628
Comments
Are other settings applied correctly? |
I'd say at least the audio output one isn't, I have to correct it on every start. I don't think I tried changing others, or I don't remember, but I could always try another one if you need/want. |
@davidebeatrici Agreed, but this only seems to affect a handful of users. People in our Matrix room are reporting the settings are being saved just fine. The question now becomes: What is the common condition that connects all users with issues. |
@Porkepix Would you be able to provide us with logs from the Developer Console? |
So I just did that, but I can only observe what's in this console after applying settings: that wouldn't work upon restart unless there's a way to get this written somewhere when the program close.
Very curiously, the first message is translated while the second isn't. It basically says the file does not exist. I'm more used about IRC, and didn't quickly see a mention about Matrix. I'll connect there as you seemed to have had questions regarding this there, in case I can also help there. EDIT: It would seems I couldn't find a publicly advertised chan. |
@Porkepix Could you please check, if the folders in this path exist? Specifically the Mumble related folders. The public Matrix room is here: https://matrix.to/#/#mumble:matrix.org |
Mmmh, I only checked the first path, not the second one. Just did, and yeah it exists. |
Also note this is something that must have happened through an update since the install, because the only shortcut I've ever set, to mute myself, has been kept. |
And to complete this answer, the directory exist. But the directory is empty. |
Some digging later, I found that
Then there's a So to sum it up, two databases, two lockfiles. One of each in the main directory, one of each in the subdirectory. But their respective date are switched. and not shared with the other file in the same directory. I hope I'm clear enough. EDIT: Some very rough scheme:
|
How does a path with |
That's just me manually anonymizing the logs I post in issues. There's my real username at this place. |
Ah okay. Now that makes sense 👍 |
Similar problem, settings are not saved, have to configure again each time you log in. Running as administrator does not help. |
Ok, wild punt, but does everyone affected by this issue have a "special character" in their path? As in, does your username contain one or more non-ASCII characters? Ping @Porkepix @Mihail-Lazarev @markusmueller73 |
It depends if you talk about 7 bits 128 characters ASCII range or 8 bits 256 characters range one. |
@Hartmnt Just found this issue because I also run into a simliar problem and for my case: Yes, the username contains an umlaut. |
@Hartmnt Same here, have an umlaut in my username. |
Nice, that gives us a reasonable assumption of what goes wrong here and why this issue is relatively rare. We let you know when we have a bugfix that you guys can test before we merge it, since we (the Mumble core team) can't reproduce this easily. |
The problem most likely occurs with the username in the native language. For example, the ASCII table does not have Russian (Cyrillic) letters. |
Hi all, I need someone who can test this experimental build: https://dev.azure.com/Mumble-VoIP/c819eb06-7b22-4ef3-bbcd-860094454eb3/_apis/build/builds/8990/artifacts?artifactName=Windows%20%28x64%29%20installer&api-version=7.1&%24format=zip Please install the version of Mumble linked above and let me know, if your settings now stick. If they do not stick, please provide the output of the Developer Console. Also note that this is from the unstable 1.6.x branch, so I would not recommend this as a daily driver. If you let me know ASAP, I might be able to get this into the next 1.5.x release. |
How about the ability for the database to downgrade, though? Also, one things I mentioned but that wasn't really visible: the settings not saving were a regression (but from when, I don't know), considering I had one shortcut saved in the past, and that one was still sticking around, but no way to add other ones. Saving servers is still working, too. |
You will probably have to fully uninstall 1.6.x as the Windows Installer does not allow software to be downgraded IIRC. So, definitely backup any data related to Mumble that you care for. The downgrade could break things and even the upgrade may possibly break something as 1.6.x is not that thoroughly tested yet.
The Mumble devs current collective assumption is that a recent Windows Update somehow broke how we were handling paths. But I can not say for sure. We all use Linux as a daily driver.
There we are interacting with a sqlite database with the proper abstraction in place. The settings file is a raw file output stream we write to. |
The error remains. |
Damn, but thank you very much for testing. |
Maybe it makes sense to make it possible to choose the path for installing the application? |
Here are the first error window, and when pressing
Nothing, I didn't touch the launcher and it's the one Mumble's setup put there.
No, but I think it's kind of the point of this issue: it looks like this file never was created for me when you moved the configs to a |
I deleted the old version and installed the new one, there was no database connection error, the server for connection was pulled up from the old version. |
This is not an option sadly, we need to work around how Windows handles encoding internally. I will be back shortly with another attempt.
Ah yes, totally makes sense. When you upgraded from 1.3 to 1.4 or somthing the old registry keys were not deleted. Now that the json/sqlite files are gone, it probably defaults to registry keys or something like that. I think you can ignore this and just create a new database for testing. |
Please note that the settings from the sql file are read and saved without errors, although the path there is the same. |
Am I to consider the registry keys were used pre-1.4 and are now all obsoletes, or are some still used? (Bonus question, if the answer is positive: is Mumble's setup removing those if we use a clean uninstall with it? Let's add more weirdness to the situation. I randomly found out that the shortcut point to It also seems that now, if I try to change the language, Mumble ask for a restart as usual, and when I answer yes, it keeps a zombie process around (without systray icon), preventing to launch Mumble anymore until I go to kill the process manually. |
Yes, I guess it would have been smart to remove the registry keys on a successful migration to json
Yes, this is already tracked by #4932 and will be fixed with the PR that rewrites the tray icon implementation |
Can those registry keys be the culprit for the last popup I posted, about shortcuts? Or it's completely unrelated? My Mumble seems to be in a quite weird state right now.
That's weird, as I believe that it didn't have this behavior when I opened this issue, and there was no update since then. Anyway, I guess we need to wait for another attempt for the settings issue here. |
Most likely related. You can disregard this as Mumble is trying to migrate your registry keys again into a json file. When you move your backup files back, those take priority. |
Unfortunately I can't test the builds currently. I only have Linux systems as well and the affected Windows laptop left town with my SO. Will do it as soon as possible (if testing is still needed then.) |
So, several things again:
From here, I don't know how to get in a cleaner state, nor how to find why it crashes (no
For my culture/understanding, what does SO stands for here? |
Debug symbols iirc
The registry keys are probably not deleted on uninstall
Possibly still related to the tray icon thing. Could you try again and if this crash keeps happening, start Mumble in a CMD and see if that prints anything useful, please? |
Unfortunately, nothing gets written in the cmd. It even gives the prompt back before it crashes. It's sometimes able to draw entirely windows and their content, but most of the time not. |
Thank you. Now everything works correctly. The settings are saved. |
Very cool. Thanks for testing, so that this can land in the next release 👍 @Porkepix At this point, I would recommend uninstalling Mumble completely again and manually removing the settings/sqlite files located in |
I already got rid of this when I did the testing… according to Windows' search (I wish I had |
@Porkepix Are you able to downgrade to 1.5? |
Presumably a recent Windows update broke the way we were using filepaths. Specifically, the internal representation of non-ASCII characters is weird in Windows and not UTF-8. Why the code we had ever worked before is unclear, but it is now broken either way. This commit introduces the boost::filesystem::path abstraction to handle the creation of raw output files gracefully on all platforms. Fixes mumble-voip#6628
Yes, I did a clean uninstall of your build, and removed everything |
Presumably a recent Windows update broke the way we were using filepaths. Specifically, the internal representation of non-ASCII characters is weird in Windows and not UTF-8. Why the code we had ever worked before is unclear, but it is now broken either way. This commit introduces the boost::filesystem::path abstraction to handle the creation of raw output files gracefully on all platforms. Fixes mumble-voip#6628
Presumably a recent Windows update broke the way we were using filepaths. Specifically, the internal representation of non-ASCII characters is weird in Windows and not UTF-8. Why the code we had ever worked before is unclear, but it is now broken either way. This commit introduces the boost::filesystem::path abstraction to handle the creation of raw output files gracefully on all platforms. Fixes mumble-voip#6628
I wanted to verify the issue is solved with the newly released Any issue related? Any way to get debug information? |
Ok, have you tried upgrading from 1.5.634 or did you delete everything before installing 1.5.735? |
Tried both, same result. |
Issue verified as fixed with latest stable once startup crash got fixed with the latest Redistributables mentioned in #6659 (comment) |
Description
On Windows (at least on 10), trying to change the language to a different from default one doesn't work (here it was specifically to switch it to English to have more accurate reports of two other bugs for Mumble).
See the STR below, but it seems impossible to change the language: setting doesn't stick after restart.
Steps to reproduce
Mumble version
1.5.634
Mumble component
Client
OS
Windows
Reproducible?
Yes
Additional information
No response
Relevant log output
I have no idea on how to gather logs from Windows, as opposed to just open this from terminal and/or checking journald for Linux.
Screenshots
N/A
The text was updated successfully, but these errors were encountered: