Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for generated munlib file sizes #419

Open
3 of 8 tasks
Wodann opened this issue Jul 7, 2022 · 2 comments
Open
3 of 8 tasks

Add benchmark for generated munlib file sizes #419

Wodann opened this issue Jul 7, 2022 · 2 comments
Assignees
Labels
exp: low Achievable with little prior knowledge and guidance good first issue Good for newcomers pri: low An issue with no impact to quality, performance, or functionality type: test Adding missing tests or correcting existing tests

Comments

@Wodann
Copy link
Collaborator

Wodann commented Jul 7, 2022

  • claim this issue (assign yourself or comment below)
  • setup repository on your local machine and make sure all tests pass (cargo test)
  • read our contributing guidelines
  • add a benchmark that compiles the Mun packages in examples/ and records the *.munlib file sizes
  • add a ci job that runs benchmarks on main and reports a warning if files sizes have increased.
  • (BONUS) Figure out a way to plot a graph, either in Rust or on our website to show the history of *.munlib file sizes.
  • start a Pull Request. Set description to closes #419. If this is your first PR, welcome 🎉 😄

Depends On

@Wodann Wodann added good first issue Good for newcomers exp: low Achievable with little prior knowledge and guidance pri: low An issue with no impact to quality, performance, or functionality type: test Adding missing tests or correcting existing tests labels Jul 7, 2022
@alexandrasp
Copy link
Contributor

@Wodann, I will start with this one. Could you assign it to me?

@Wodann
Copy link
Collaborator Author

Wodann commented Jul 6, 2023

Great choice, thank you!

@alexandrasp alexandrasp mentioned this issue Jul 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp: low Achievable with little prior knowledge and guidance good first issue Good for newcomers pri: low An issue with no impact to quality, performance, or functionality type: test Adding missing tests or correcting existing tests
Projects
None yet
Development

No branches or pull requests

2 participants