Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve item tree display #547

Merged

Conversation

baszalmstra
Copy link
Collaborator

A refactor to format ItemTrees properly. I need this for testing impls.

@baszalmstra baszalmstra added the type: refactor Refactor existing code label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5b87d1a) 87.13% compared to head (3fa196e) 87.11%.

Files Patch % Lines
crates/mun_hir/src/pretty.rs 75.67% 9 Missing ⚠️
crates/mun_hir/src/item_tree/pretty.rs 98.13% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   87.13%   87.11%   -0.02%     
==========================================
  Files         269      271       +2     
  Lines       31103    31273     +170     
==========================================
+ Hits        27102    27244     +142     
- Misses       4001     4029      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baszalmstra baszalmstra force-pushed the refactor/improve_item_tree_display branch from b166178 to 3fa196e Compare December 28, 2023 20:22
@baszalmstra baszalmstra merged commit 99e5217 into mun-lang:main Dec 28, 2023
18 checks passed
@Wodann Wodann added this to the Mun v0.5.0 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Refactor existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants