fix: don't perform invalid reference cast #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces it with a raw pointer. Avoids possible Undefined Behavior.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 87.30% 87.25% -0.06%
==========================================
Files 276 276
Lines 31970 31966 -4
==========================================
- Hits 27912 27891 -21
- Misses 4058 4075 +17 ☔ View full report in Codecov by Sentry. |
baszalmstra
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces it with a raw pointer. Avoids possible Undefined Behavior.
Stripped-down example of how the current code fails in Miri: playground
Equivalent using the implementation from this PR: playground