Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(How to include or link) Plugins in non-scripting language (like Rust) #1311

Open
Ganneff opened this issue May 21, 2022 · 0 comments
Open

Comments

@Ganneff
Copy link

Ganneff commented May 21, 2022

Hi,

I would like to include some plugins here (or better: have them linked from the Plugin Gallery), but it is not as trivial as a simple Pull Request: They are not in a scripting language. The plugins are Rust source, and as such need a Rust environment to compile and do not fit some of your requirements.

How to best go about making them more available to others?

More info:

I wrote a Rust crate (library), munin-plugin (Github, docs), which (IMO) makes writing Munin Plugins in Rust plenty simple. I have written one CPU graph plugin with 1-second resolution which can do plain "total" graphs or multigraph for each CPU core, one Interface graph plugin with 1-second resolution using that crate, and am in process of converting my Fibre Channel SAN stats graph plugin over to this lib. I also converted the plain load graph to it, but that was more to see how a simple plugin goes.

Including the Rust crate in the munin-monitoring/contrib repo doesn't make too much sense - Rust with it's package manager use crates.io. Including the Rust code of the plugins could be done, but then ideally each plugin would have it's own subdir, as one needs at least Cargo.toml too, including Cargo.lock also makes sense.

Next issue would be the wanted documentation/tags. Could probably be put into
/*
[...]
*/
block comments, so Rust ignores them. As long as the Gallery generator is happy with that?

Alternative idea would be to include "stub" files, that just have the neccessary comments, but otherwise link to the real GitHub Repos for the Plugins?

What do you think is the best way about it?

Ganneff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant