From 82e4f7bfe2b544f3f5765d5935c1f3178560e075 Mon Sep 17 00:00:00 2001 From: Thierry Bissler Date: Sun, 16 Dec 2018 18:46:03 +0100 Subject: [PATCH 1/4] =?UTF-8?q?Tablature=20par=20d=C3=A9faut=20en=20positi?= =?UTF-8?q?on=20Lower,=20et=20pas=20d'=C3=A9criture=20de=20la=20tablature?= =?UTF-8?q?=20si=20on=20est=20sur=20une=20note=20li=C3=A9e?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- harmonica_tablature.qml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/harmonica_tablature.qml b/harmonica_tablature.qml index 1aca248..e1ebbd9 100644 --- a/harmonica_tablature.qml +++ b/harmonica_tablature.qml @@ -239,8 +239,12 @@ MuseScore { if (typeof tab === "undefined") text.text = "X"; else { - if (bendChar !== "b") + if (notes[i].tieBack != null) { + // Pas de tablature si la note est une note liée + tab = "" + } else if (bendChar !== "b") { tab = tab.replace(/b/g, bendChar); + } text.text = tab + text.text; } } From 80efba148c1f5e9907306e1fce590eb669b45501 Mon Sep 17 00:00:00 2001 From: Thierry Bissler Date: Sun, 16 Dec 2018 19:29:37 +0100 Subject: [PATCH 2/4] Comments in english --- harmonica_tablature.qml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/harmonica_tablature.qml b/harmonica_tablature.qml index e1ebbd9..eff1287 100644 --- a/harmonica_tablature.qml +++ b/harmonica_tablature.qml @@ -100,7 +100,9 @@ MuseScore { } } ComboBox { - currentIndex: 1 + currentIndex: 3 + // Lower by default, prefered harp players' position + // Lower par défaut, position préférée des harmonicistes model: ListModel { id: placetext property var position @@ -240,6 +242,7 @@ MuseScore { text.text = "X"; else { if (notes[i].tieBack != null) { + // No tab if the note is tied // Pas de tablature si la note est une note liée tab = "" } else if (bendChar !== "b") { From 5731918ba17a0101af67e654ff4d9a040b3864a1 Mon Sep 17 00:00:00 2001 From: Thierry Bissler Date: Sun, 16 Dec 2018 19:48:14 +0100 Subject: [PATCH 3/4] Version and credits --- harmonica_tablature.qml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/harmonica_tablature.qml b/harmonica_tablature.qml index eff1287..330a3ed 100644 --- a/harmonica_tablature.qml +++ b/harmonica_tablature.qml @@ -17,8 +17,8 @@ import QtQuick.Layouts 1.1 import MuseScore 1.0 MuseScore { - version: "2.0" - description: "Harmonica Tab plugin" + version: "2.1" + description: "Harmonica Tab plugin\nhttps://github.com/lasconic/harmonica_tablature\nContributors: Lasconic, Thierz" menuPath: "Plugins.Harmonica Tablature" pluginType: "dialog" From a67281153d385733b7b15db154977e4d620bc2c1 Mon Sep 17 00:00:00 2001 From: Thierry Bissler Date: Sun, 16 Dec 2018 20:05:21 +0100 Subject: [PATCH 4/4] Indentation --- harmonica_tablature.qml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/harmonica_tablature.qml b/harmonica_tablature.qml index 330a3ed..7c73901 100644 --- a/harmonica_tablature.qml +++ b/harmonica_tablature.qml @@ -101,8 +101,8 @@ MuseScore { } ComboBox { currentIndex: 3 - // Lower by default, prefered harp players' position - // Lower par défaut, position préférée des harmonicistes + // Lower by default, prefered harp players' position + // Lower par défaut, position préférée des harmonicistes model: ListModel { id: placetext property var position @@ -241,13 +241,13 @@ MuseScore { if (typeof tab === "undefined") text.text = "X"; else { - if (notes[i].tieBack != null) { - // No tab if the note is tied - // Pas de tablature si la note est une note liée - tab = "" - } else if (bendChar !== "b") { + if (notes[i].tieBack != null) { + // No tab if the note is tied + // Pas de tablature si la note est une note liée + tab = "" + } else if (bendChar !== "b") { tab = tab.replace(/b/g, bendChar); - } + } text.text = tab + text.text; } }