Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orxporter crashes when an unknown export format is passed #35

Open
shello opened this issue Mar 16, 2020 · 0 comments
Open

Orxporter crashes when an unknown export format is passed #35

shello opened this issue Mar 16, 2020 · 0 comments

Comments

@shello
Copy link
Contributor

shello commented Mar 16, 2020

When a unknown format is passed to -F, orxporter's threads crash:

x∆∆x Thread 0 failed: must be str, not type

Traceback (most recent call last):
  File "/.../orxporter/export_thread.py", line 153, in run
    final_path = dest_paths.format_path(self.path, emoji, f)
  File "/.../orxporter/dest_paths.py", line 99, in format_path
    raise ValueError('Invalid export format: ' + FilterException)
TypeError: must be str, not type

(obtaining this traceback requires PR #34)

The referenced line is:

raise ValueError('Invalid export format: ' + FilterException)

Was this ValueError meant to be a FilterException, and the format string being concatenated to the message (instead of the FilterException class, which makes orxporter crash without a helpful message)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant