Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localshop Frontpage Text Personalization #65

Open
lovato opened this issue Jun 12, 2013 · 6 comments
Open

Localshop Frontpage Text Personalization #65

lovato opened this issue Jun 12, 2013 · 6 comments

Comments

@lovato
Copy link
Collaborator

lovato commented Jun 12, 2013

Suggestion:

add 2 new variables to conf.py (and mantain defaults with the strings currently available hardcoded inside the template):

  • FRONTPAGE_TITLE
  • FRONTPAGE_SUBTITLE

And use those on frontpage.html, here:

Localshop

<p>Welcome to your localshop!</p>

We have 2 localshop instalations, and its a good idea to identify which one is targeted for testing, and which one is production.

@lovato
Copy link
Collaborator Author

lovato commented Jun 12, 2013

Then I may have:

Localshop DSV

<p>Testing Environment Only</p>

@mvantellingen
Copy link
Owner

Hey, since i'm really short on time currently i've added you as committer. So go ahead and help me make it better! :-)

@lovato
Copy link
Collaborator Author

lovato commented Jun 12, 2013

Sure I will.

Best
Em 12/06/2013 12:54, "Michael" [email protected] escreveu:

Hey, since i'm really short on time currently i've added you as committer.
So go ahead and help me make it better! :-)


Reply to this email directly or view it on GitHubhttps://github.com//issues/65#issuecomment-19335333
.

@llonchj
Copy link
Collaborator

llonchj commented Jun 20, 2013

It will be nice also to FRONTPAGE_SHOW_MESSAGE = True/False to enable and disable the whole message.

The suggested setting key (FRONTPAGE_SHOW_MESSAGE) it is only a idea, you might find a better key name to define the functionality.

This leads to me that some TEMPLATE_CONTEXT_PROCESSOR will need to be added to make settings visible from templates.

@lovato
Copy link
Collaborator Author

lovato commented Jun 22, 2013

Yes, you are correct. Will take a deep look on my localshop instalation to see any other possible personalisation. Tks.

@llonchj
Copy link
Collaborator

llonchj commented Jun 22, 2013

You're welcome. it will be good to expose the whole settings to the templating system, then any template will be able to render based on any setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants