Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in MLproject and wrong comparison in _already_ran (main.py) #1

Open
cr4zy-C opened this issue Aug 1, 2019 · 0 comments
Open

Comments

@cr4zy-C
Copy link

cr4zy-C commented Aug 1, 2019

Hi,
very nice project! I found a typo in the MLproject file (entrypoint: main) that lets the mlflow run command fail:
Typo char ["]
bucket_name" {type:string, default: stock-market-models}
Should be char [:]
bucket_name: {type:string, default: stock-market-models}

In main.py the chaching does not work for me, because in the _already_ran function there are some string, int comparisons.

I found the following:
run_value = full_run.data.params.get(param_key) if run_value != param_value:
run_value stores the value as a string, but param_value stores it as an int -> comparison does not work as expected.
I fixed it for myself with following:
if type(run_value) != type(param_value): param_value = str(param_value)

if run_info.status != RunStatus.FINISHED:
run_info.status stores 'FINISHED' as string, but RunStatus.FINISHED is stored as enum = int -> comparison does not work as expected.
I fixed it with the following:
if run_info.status != RunStatus.to_string(RunStatus.FINISHED):

After these changes the workflow worked for me and it reused the already executed steps correctly.
I ran it with python 3.7.3 I don't know if that caused the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant