Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitter (non-smooth) animations. Most noticable at slower speeds. #16

Open
sambernaerdt opened this issue Sep 8, 2023 · 2 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@sambernaerdt
Copy link
Contributor

First of all: Thanks again for putting this together.

I did notice that at slower speeds, the animation is not super smooth. It looks like it gets rounded to some values. As soon as the speed increases, it gets less noticable.

Some examples where it is visible:

@mwydmuch mwydmuch added the enhancement New feature or request label Sep 11, 2023
@mwydmuch
Copy link
Owner

Yes, I'm aware of that, it happens because image cropping in both image backends requires rounding to the integer pixel coordinates. Let me think about how to solve it in the best possible way.
I guess the one resource-costly solution is to increase the internal resolution of the images, this will give the best result, and smooth animation. The second option is to better control rounding, sacrificing a bit of smoothness (no jitter but possibly visible pixel size shifts).

@sambernaerdt
Copy link
Contributor Author

IMHO: I wouldn't mind the sacrifice of longer render times if that is a quick fix to increase the smoothness. I have no clue at what magnitudes of render time increase we are looking here, but I guess it could work when it's an argument to opt-in when desired.

  • Set it at 1 (or whatever the default is) to do a test run until everything looks good.
  • Set it to a higher value and be patient for the final render.

@mwydmuch mwydmuch added this to the 0.4.0 milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants