Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the sample LIST View #1175

Open
jbflo opened this issue Mar 12, 2024 · 4 comments
Open

Refactoring of the sample LIST View #1175

jbflo opened this issue Mar 12, 2024 · 4 comments

Comments

@jbflo
Copy link
Member

jbflo commented Mar 12, 2024

Issue

  • Files content are too big
  • Sample List slow on Render when having 200 ++ Samples / but way better when build.
  • Slow because of complex array filter.

To DO

  • Transform to functional and smaller component
  • Mapping of the Array differently ? to increase render Robustness

Not Urgent : Some help / Suggestion are welcome

@jbflo jbflo self-assigned this Mar 12, 2024
@axelboc
Copy link
Collaborator

axelboc commented Mar 12, 2024

TODO seems legit: first refactor to functional/smaller components, extract utility functions, improve data structures, etc. and only after optimise with memoisation (useMemo, useCallback).

@jbflo jbflo removed their assignment Jun 4, 2024
@marcus-oscarsson
Copy link
Member

@jbflo: Are you happy with the performance now are there still things that needs to be improved ?

@jbflo
Copy link
Member Author

jbflo commented Jun 12, 2024

@jbflo: Are you happy with the performance now are there still things that needs to be improved ?

Performance is more or less okay, As i don't hear scientist complain.

But more importantly is the code style : at some point i wanted to refactor to functional/smaller components, extract utility functions, and improve data structures.

I suggest to keep this open for now, and maybe someone else would be interest to have a look.

@marcus-oscarsson marcus-oscarsson changed the title Refactoring of the sample LIST View ?? Refactoring of the sample LIST View Jun 28, 2024
@marcus-oscarsson
Copy link
Member

@jbflo I see, sounds good to split into smaller functional components 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants