Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step input popover is a bit cumbersome to use #1311

Closed
axelboc opened this issue Jul 11, 2024 · 1 comment · Fixed by #1429
Closed

Step input popover is a bit cumbersome to use #1311

axelboc opened this issue Jul 11, 2024 · 1 comment · Fixed by #1429
Assignees

Comments

@axelboc
Copy link
Collaborator

axelboc commented Jul 11, 2024

The step input popover has a few flaws:

  • It requires too many user interactions to change the step.
  • The up/down arrow buttons to adjust the step are apparently rarely used because it's often quicker to enter a value manually (especially since some of the increments are not well configured by default - e.g. 0.1 for Omega is way too small).
  • The checkmark button feels unnecessary since one is already typing a value, so pressing Enter is faster.
  • When the step changes, the motor input becomes "dirty" for no apparent reason (i.e. orange background, indicating that the value of the input has changed but hasn't yet been sent to the server).

Peek 2024-07-11 11-14

Proposal: Turn the step value into an input field that can be edited directly and committed with Enter (no up/down arrow buttons). The step input should be marked as dirty when edited but not yet committed (but not the motor input).

This solution would also greatly simplify the logic of the step component, since it currently deals with disabling the popover behaviour when the motor input is already displayed inside a popover:

image

@marcus-oscarsson
Copy link
Member

Yes, the step function is indeed not used very often. Your suggestions sounds good to me as well, lets go for that if there are no other objections :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants