Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: installing a development environment #1384

Closed
woutdenolf opened this issue Aug 30, 2024 · 5 comments · Fixed by #1412
Closed

Docs: installing a development environment #1384

woutdenolf opened this issue Aug 30, 2024 · 5 comments · Fixed by #1412

Comments

@woutdenolf
Copy link

woutdenolf commented Aug 30, 2024

https://mxcubeweb.readthedocs.io/en/latest/dev/environment.html#create-the-mxcubeweb-conda-environment

It mentions this command, but this is not a valid conda command:

conda env create -f conda-environment.yml python=3.9

SpecNotFound: Invalid name 'python=3.9', try the format: user/package

There is no one-step way of doing this afaik. Hence this open issue: conda/conda#12313.

@fabcor-maxiv
Copy link
Contributor

Related but different issue: #1383, in this other issue we address the fact that resolving for Python 3.9 (and 3.8, but not 3.10 and 3.11) would fail anyway.

@marcus-oscarsson
Copy link
Member

marcus-oscarsson commented Sep 18, 2024

Where are we with this, do we recommend people to use conda i.e. doing something like:

conda env create --name mxcubeweb python=3.x
conda env update --name mxcubeweb -f conda-environment.yml

It seems like @fabcor-maxiv mentioned that one could do it in one go using micromamba:

micromamba create -f conda-environment.yml 'python==3.8' 

I don't really have a strong opinion about it, but there is perhaps something I overlooked with this. It would be nice if we could update the documentation accordingly though :)

@fabcor-maxiv
Copy link
Contributor

I still want to investigate this, and I am open to input from others.

I almost always use micromamba, I sometimes use mamba, and I almost never use conda. As far as I know most people use conda, so we should aim to find something that works for conda.

We could also simply remove this block from the documentation and let it to people to figure it out on their own if they need this. Maybe we should review why we added this block in the first place.

@marcus-oscarsson
Copy link
Member

Closing as replaced by #1383 and #1410

@fabcor-maxiv fabcor-maxiv reopened this Sep 20, 2024
fabcor-maxiv added a commit to fabcor-maxiv/mxcubeweb that referenced this issue Sep 20, 2024
This fixes the instructions for creating a development environment
for a specific Python version.

GitHub: fix mxcube#1384
fabcor-maxiv added a commit to fabcor-maxiv/mxcubeweb that referenced this issue Sep 20, 2024
This fixes the instructions for switching to a specific Python version
in the development conda environment.

GitHub: fix mxcube#1384
@fabcor-maxiv
Copy link
Contributor

I am going with conda and two commands: #1412.

fabcor-maxiv added a commit to fabcor-maxiv/mxcubeweb that referenced this issue Sep 25, 2024
This fixes the instructions for switching to a specific Python version
in the development conda environment.

GitHub: fix mxcube#1384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants