Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to stop transcription on 0.4.0 #183

Open
EightPool opened this issue Jan 9, 2024 · 4 comments
Open

Unable to stop transcription on 0.4.0 #183

EightPool opened this issue Jan 9, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@EightPool
Copy link

EightPool commented Jan 9, 2024

I was testing the latest RC version and noticed that the stop method is broken on iOS since 0.4.0-rc.5. Also, it appears that the stop method issue on Android has not been resolved with #143.

Is there a new method to abort the transcription of a file instead of using stop() ?

@jhen0409
Copy link
Member

Fixed in 1421c55 and d1541ae.

@jhen0409 jhen0409 added the bug Something isn't working label Jan 17, 2024
@sdip15fa
Copy link

Hello, after trying v4.0.0-rc.7, it appears that transcription still cannot be stopped.

@jhen0409
Copy link
Member

jhen0409 commented Jan 19, 2024

Due to recent whisper.cpp changes, the abort callback is not used in ggml_graph_compute_helper anymore. The abort_callback only used in whisper_encode_internal / whisper_decode_internal now.

I'll look at the reasons for this change later.

@jhen0409 jhen0409 reopened this Jan 24, 2024
@jobpaardekooper
Copy link
Contributor

@jhen0409 Do you have any update on this? Just tried out the newest RC and having the gpu optional available is incredibly great. Sadly this issue is a real blocker for a full 4.0 release.

Any help needed from the community? If so it would be nice to have a few extra pointers on this.

Thanks for all the work on this great library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants