Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Make the calendar highlight the current date by default when opening. #247

Open
ajboni opened this issue Sep 13, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ajboni
Copy link

ajboni commented Sep 13, 2024

A really small FR

Is your feature request related to a problem? Please describe.
If you open the calendar and select another date, and then close it. The next time you open it shows that date as default. It's confusing!

Describe the solution you'd like
I'd like to always highlight the current date when is open

BTW, will you accept PR for this? this could potentially be a good first issue for me to learn a bit about the project

@ajboni ajboni added the enhancement New feature or request label Sep 13, 2024
@mylinuxforwork
Copy link
Owner

@ajboni Crazy this should already work like you described it. I will check.

@mylinuxforwork mylinuxforwork added the to be confirmed Issue is currently under review and has not been released label Sep 15, 2024
@mylinuxforwork mylinuxforwork removed the to be confirmed Issue is currently under review and has not been released label Sep 25, 2024
@mylinuxforwork
Copy link
Owner

@ajboni THis is how it looks in the latest version.

image

@ajboni
Copy link
Author

ajboni commented Sep 26, 2024

I've double checked and it still has the same behavior (every time you open it, you get the last date you clicked)

I've asked the developer and the fix is to select the current date explicitly when opening the calendar

App.connect("window-toggled", (_, name, visible) => {
  if (visible && name == yourWindow.name) {
    // select the day on calender
  }
})

@mylinuxforwork
Copy link
Owner

Now I got your point. Will fix it.

@mylinuxforwork mylinuxforwork added this to the v2.9.7 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants