From daed00b0e646f80cf7dbbaea6a1ac6f558296a7e Mon Sep 17 00:00:00 2001
From: Netfan <netfan@foxmail.com>
Date: Thu, 5 Dec 2024 11:50:56 +0800
Subject: [PATCH] fix: layout and `Page` style adjustment, fixed #5021 #5027

---
 .../ui-kit/layout-ui/src/vben-layout.vue      |  2 +-
 .../common-ui/src/components/page/page.vue    | 94 ++++++++++++++-----
 .../src/views/examples/vxe-table/basic.vue    |  1 +
 3 files changed, 70 insertions(+), 27 deletions(-)

diff --git a/packages/@core/ui-kit/layout-ui/src/vben-layout.vue b/packages/@core/ui-kit/layout-ui/src/vben-layout.vue
index 98932e250ba..a598f291384 100644
--- a/packages/@core/ui-kit/layout-ui/src/vben-layout.vue
+++ b/packages/@core/ui-kit/layout-ui/src/vben-layout.vue
@@ -503,7 +503,7 @@ function handleHeaderToggle() {
 
     <div
       ref="contentRef"
-      class="flex flex-1 flex-col transition-all duration-300 ease-in"
+      class="flex flex-1 flex-col overflow-hidden transition-all duration-300 ease-in"
     >
       <div
         :class="[
diff --git a/packages/effects/common-ui/src/components/page/page.vue b/packages/effects/common-ui/src/components/page/page.vue
index a7fea6a5ae4..76cd4ca7381 100644
--- a/packages/effects/common-ui/src/components/page/page.vue
+++ b/packages/effects/common-ui/src/components/page/page.vue
@@ -9,8 +9,16 @@ import {
 } from 'vue';
 
 import { preferences } from '@vben-core/preferences';
+import {
+  CSS_VARIABLE_LAYOUT_CONTENT_HEIGHT,
+  CSS_VARIABLE_LAYOUT_CONTENT_WIDTH,
+  CSS_VARIABLE_LAYOUT_FOOTER_HEIGHT,
+  CSS_VARIABLE_LAYOUT_HEADER_HEIGHT,
+} from '@vben-core/shared/constants';
 import { cn } from '@vben-core/shared/utils';
 
+import { useElementSize } from '@vueuse/core';
+
 interface Props {
   title?: string;
   description?: string;
@@ -37,34 +45,65 @@ const {
   fixedHeader = false,
 } = defineProps<Props>();
 
-const headerHeight = ref(0);
-const footerHeight = ref(0);
 const shouldAutoHeight = ref(false);
 
 const headerRef = useTemplateRef<HTMLDivElement>('headerRef');
 const footerRef = useTemplateRef<HTMLDivElement>('footerRef');
+const { height: headerHeight } = useElementSize(
+  headerRef,
+  {
+    height: 0,
+    width: 0,
+  },
+  { box: 'border-box' },
+);
+const { height: footerHeight } = useElementSize(
+  footerRef,
+  {
+    height: 0,
+    width: 0,
+  },
+  { box: 'border-box' },
+);
 
 const headerStyle = computed<StyleValue>(() => {
   return fixedHeader
     ? {
-        position: 'sticky',
+        position: 'fixed',
         zIndex: 200,
+        width: `var(${CSS_VARIABLE_LAYOUT_CONTENT_WIDTH})`,
         top:
-          preferences.header.mode === 'fixed' ? 'var(--vben-header-height)' : 0,
+          preferences.header.mode === 'fixed'
+            ? `var(${CSS_VARIABLE_LAYOUT_HEADER_HEIGHT})`
+            : 0,
       }
     : undefined;
 });
 
+const footerStyle = computed<StyleValue>(() => {
+  return {
+    bottom:
+      preferences.footer.enable && preferences.footer.fixed
+        ? `var(${CSS_VARIABLE_LAYOUT_FOOTER_HEIGHT})`
+        : 0,
+    width: `var(${CSS_VARIABLE_LAYOUT_CONTENT_WIDTH})`,
+  };
+});
+
 const contentStyle = computed(() => {
+  const style: StyleValue = {};
+  if (headerHeight.value > 0 && fixedHeader) {
+    style.marginTop = `${headerHeight.value}px`;
+  }
+  if (footerHeight.value > 0) {
+    style.marginBottom = `${footerHeight.value}px`;
+  }
   if (autoContentHeight) {
-    return {
-      height: shouldAutoHeight.value
-        ? `calc(var(--vben-content-height) - ${headerHeight.value}px - ${footerHeight.value}px)`
-        : '0',
-      // 'overflow-y': shouldAutoHeight.value?'auto':'unset',
-    };
+    style.height = shouldAutoHeight.value
+      ? `calc(var(${CSS_VARIABLE_LAYOUT_CONTENT_HEIGHT}) - ${headerHeight.value}px - ${footerHeight.value}px)`
+      : '0';
   }
-  return {};
+  return style;
 });
 
 async function calcContentHeight() {
@@ -97,7 +136,7 @@ onMounted(() => {
       ref="headerRef"
       :class="
         cn(
-          'bg-card relative px-6 py-4',
+          'bg-card relative flex gap-2 px-6 py-4',
           headerClass,
           fixedHeader
             ? 'border-border border-b transition-all duration-200'
@@ -106,19 +145,21 @@ onMounted(() => {
       "
       :style="headerStyle"
     >
-      <slot name="title">
-        <div v-if="title" class="mb-2 flex text-lg font-semibold">
-          {{ title }}
-        </div>
-      </slot>
-
-      <slot name="description">
-        <p v-if="description" class="text-muted-foreground">
-          {{ description }}
-        </p>
-      </slot>
-
-      <div v-if="$slots.extra" class="absolute bottom-4 right-4">
+      <div class="flex-auto">
+        <slot name="title">
+          <div v-if="title" class="mb-2 flex text-lg font-semibold">
+            {{ title }}
+          </div>
+        </slot>
+
+        <slot name="description">
+          <p v-if="description" class="text-muted-foreground">
+            {{ description }}
+          </p>
+        </slot>
+      </div>
+
+      <div v-if="$slots.extra" class="mb-2 self-end">
         <slot name="extra"></slot>
       </div>
     </div>
@@ -133,9 +174,10 @@ onMounted(() => {
       :class="
         cn(
           footerClass,
-          'bg-card align-center absolute bottom-0 left-0 right-0 flex px-6 py-4',
+          'bg-card align-center border-border fixed right-0 flex border-t px-6 py-4 transition-all duration-200',
         )
       "
+      :style="footerStyle"
     >
       <slot name="footer"></slot>
     </div>
diff --git a/playground/src/views/examples/vxe-table/basic.vue b/playground/src/views/examples/vxe-table/basic.vue
index 1216468d4d8..9e4e336d89a 100644
--- a/playground/src/views/examples/vxe-table/basic.vue
+++ b/playground/src/views/examples/vxe-table/basic.vue
@@ -71,6 +71,7 @@ function changeLoading() {
 <template>
   <Page
     description="表格组件常用于快速开发数据展示与交互界面，示例数据为静态数据。该组件是对vxe-table进行简单的二次封装，大部分属性与方法与vxe-table保持一致。"
+    fixed-header
     title="表格基础示例"
   >
     <template #extra>